Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmap: lua scripting support is optional #57822

Merged
merged 1 commit into from Mar 18, 2019
Merged

nmap: lua scripting support is optional #57822

merged 1 commit into from Mar 18, 2019

Conversation

illegalprime
Copy link
Member

Motivation for this change

adds the ability to disable lua support in nmap, this is useful when lua cross-compilation isn't working, and to produce smaller static binaries of nmap.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Mar 18, 2019

Is cross-building lua fixable ? do you have an example/command where it fails ?

@Mic92
Copy link
Member

Mic92 commented Mar 18, 2019

I think fixing lua cross-compiling is orthogonal to this issue. Having a smaller nmap sounds reasonable to me.

@Mic92 Mic92 merged commit b16f32a into NixOS:master Mar 18, 2019
@illegalprime
Copy link
Member Author

@teto not sure, haven't looked into it yet. it probably is though

@teto
Copy link
Member

teto commented Mar 18, 2019

Not like I would have had the time to fix it but would have been interesting to get some knowledge on how bad it is. Hopefully someone else needs it and fixes it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@illegalprime @teto @Mic92 @GrahamcOfBorg