Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdfsandwich: init at 0.1.7 #57869

Merged
merged 1 commit into from Mar 24, 2019
Merged

pdfsandwich: init at 0.1.7 #57869

merged 1 commit into from Mar 24, 2019

Conversation

robertseaton
Copy link
Contributor

Motivation for this change

Needed to OCR a PDF. The community was so {nice, helpful, generally wonderful} regarding my last contribution attempt, thought I'd try to package pdfsandwich too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ X ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ X ] Assured whether relevant documentation is up to date
  • [ X ] Fits CONTRIBUTING.md.

@etu
Copy link
Contributor

etu commented Mar 19, 2019

Commit message should be: pdfsandwich: init at 0.1.7

etu
etu requested changes Mar 19, 2019
View reviewed changes
pkgs/tools/typesetting/pdfsandwich/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/pdfsandwich/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/pdfsandwich/default.nix Outdated Show resolved Hide resolved
@robertseaton robertseaton changed the title init: pdfsandwich at 0.1.7 pdfsandwich: init at 0.1.7 Mar 19, 2019
@etu
Copy link
Contributor

etu commented Mar 24, 2019

@GrahamcOfBorg build pdfsandwich

@robertseaton It would be nice if you could squash your commits to one commit :-)

@robertseaton
Copy link
Contributor Author

robertseaton commented Mar 24, 2019 •
edited

@etu Sounds good, squashed to one commit! :-)

@etu etu merged commit 0ee682d into NixOS:master Mar 24, 2019
@etu
Copy link
Contributor

etu commented Mar 24, 2019

@robertseaton Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

@etu etu etu approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@robertseaton @etu @pSub @GrahamcOfBorg