gtk-wave-cleaner: init at 0.22-01 #57870
Conversation
balsoft
force-pushed
the
gtk-wave-cleaner-init
branch
5 times, most recently
from
190e2c8
to
82900da
Compare
| cliSupport ? true, perl ? null, | ||
| xdgSupport ? true, xdg_utils ? null | ||
| }: | ||
| assert pulseSupport || alsaSupport || (builtins.match ".*-darwin" stdenv.system != null); |
There was a problem hiding this comment.
| assert pulseSupport || alsaSupport || (builtins.match ".*-darwin" stdenv.system != null); | |
| assert pulseSupport || alsaSupport || (builtins.match ".*-darwin" stdenv.system != null); |
There was a problem hiding this comment.
Why not use stdenv.isDarwin?
|
If you have other prs please consider these styling suggestions there. Additionally we prefer to rebase vs merging 3a95c1d. |
|
Thank you very much for spending your time, I am going to apply those suggestions to other PR's. |
balsoft
force-pushed
the
gtk-wave-cleaner-init
branch
from
82900da
to
477ce31
Compare
|
@worldofpeace I believe I have fixed all of those problems, if you see more, please correct me! I'm a new contributor, so showing where I'm wrong is the best possible way to learn. |
Totally, though please note I don't believe in mistakes. Only learning opportunities 👍 . |
|
Hmm I couldn't test this with audio produced with any version of ffmpeg in nixpkgs Guess it could be still useful. |
|
@GrahamcOfBorg build gtk-wave-cleaner |
1 similar comment
|
@GrahamcOfBorg build gtk-wave-cleaner |
| cliSupport ? true, perl ? null, | ||
| xdgSupport ? true, xdg_utils ? null | ||
| }: | ||
| assert pulseSupport || alsaSupport || (builtins.match ".*-darwin" stdenv.system != null); |
There was a problem hiding this comment.
Why not use stdenv.isDarwin?
| stdenv, gnumake, autoconf, automake, pkgconfig, | ||
| libsndfile, gtk2, fftw, | ||
| pulseSupport ? stdenv.config.pulseaudio or false, alsaSupport ? true, | ||
| libpulseaudio ? null, pulseaudio ? null, alsaLib ? null, |
There was a problem hiding this comment.
| libpulseaudio ? null, pulseaudio ? null, alsaLib ? null, | |
| pulseaudio ? null, alsaLib ? null, |
| }: | ||
|
|
||
| assert pulseSupport || alsaSupport || (builtins.match ".*-darwin" stdenv.system != null); | ||
| assert pulseSupport -> libpulseaudio != null && pulseaudio != null; |
There was a problem hiding this comment.
| assert pulseSupport -> libpulseaudio != null && pulseaudio != null; | |
| assert pulseSupport -> pulseaudio != null; |
| automake | ||
| ]; | ||
|
|
||
| preConfigure = "autoreconf -i"; |
There was a problem hiding this comment.
You can use autoreconfHook in nativeBuildInputs instead of this and ac and am.
| }; | ||
|
|
||
| nativeBuildInputs = [ | ||
| gnumake |
There was a problem hiding this comment.
Make should be always available, or does this need GNU variant specifically? It should probably be commented in that case.
|
@balsoft Are you still interested in finishing this? |
|
@veprbl it was a package I made for someone else, so no, not really. It would be nice to have it in nixpkgs, but said person is fine using it from an overlay. |
|
Let's close. |
Motivation for this change
This PR adds gtk-wave-cleaner, an old but still viable piece of software for cleaning sounds.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)