Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] python.pkgs.pyzmq: disable flaky test #57765

Merged
merged 1 commit into from Mar 16, 2019
Merged

[19.03] python.pkgs.pyzmq: disable flaky test #57765

merged 1 commit into from Mar 16, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 16, 2019

Motivation for this change

Recently failed on staging.

(cherry picked from commit 4f2d842)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
python.pkgs.pyzmq: disable flaky test
d7b486f 
Recently failed on staging.

(cherry picked from commit 4f2d842)
@timokau timokau requested a review from FRidh as a code owner March 16, 2019 18:48
@veprbl veprbl changed the title python.pkgs.pyzmq: disable flaky test [19.03] python.pkgs.pyzmq: disable flaky test Mar 16, 2019
@timokau timokau merged commit ac2ceb0 into NixOS:release-19.03 Mar 16, 2019
@timokau timokau deleted the pyzmq-flaky-test-19.03 branch March 16, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg