Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commandergenius: update and move to gitlab #57740

Merged
merged 1 commit into from Mar 18, 2019
Merged

commandergenius: update and move to gitlab #57740

merged 1 commit into from Mar 18, 2019

Conversation

stephengroat
Copy link
Contributor

@stephengroat stephengroat commented Mar 16, 2019 •
edited

update and move to gitlab (repo has moved)
update fixes build (https://hydra.nixos.org/build/90482453/nixlog/2) for #56826

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Mar 16, 2019

@GrahamcOfBorg build commandergenius

@xeji
Copy link
Contributor

xeji commented Mar 16, 2019

Somehow the build didn't happen, try again:
@GrahamcOfBorg build commandergenius

@stephengroat
commandergenius: update and move to gitlab
3dea044 
update and move to gitlab (repo has moved)
update fixes build (https://hydra.nixos.org/build/90482453/nixlog/2) for NixOS#56826
@xeji
Copy link
Contributor

xeji commented Mar 18, 2019

@GrahamcOfBorg build commandergenius

@xeji
Copy link
Contributor

xeji commented Mar 18, 2019

Thank you!

@xeji xeji merged commit 84903aa into NixOS:master Mar 18, 2019
xeji pushed a commit that referenced this pull request Mar 18, 2019
@stephengroat @xeji
commandergenius: update and move to gitlab (#57740)
74e25d2 
update and move to gitlab (repo has moved)
update fixes build (https://hydra.nixos.org/build/90482453/nixlog/2) for #56826

(cherry picked from commit 84903aa)
@xeji
Copy link
Contributor

xeji commented Mar 18, 2019

backported to 19.03 in 74e25d2

@stephengroat stephengroat deleted the patch-2 branch March 18, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephengroat @xeji @GrahamcOfBorg