Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: Update to 11.9.0 #57774

Merged
merged 2 commits into from
Mar 26, 2019
Merged

gitlab: Update to 11.9.0 #57774

merged 2 commits into from
Mar 26, 2019
+788 −501

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Mar 17, 2019 •
edited
Loading

Motivation for this change

Just a regular version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg requested review from fpletz and globin March 17, 2019 00:43
@bgamari bgamari force-pushed the update-gitlab branch 2 times, most recently from 87207c8 to 24130f2 Compare March 23, 2019 00:29
@bgamari bgamari changed the title gitlab: Update to 11.8.2 gitlab: Update to 11.9.0 Mar 23, 2019
@bgamari bgamari requested a review from infinisil as a code owner March 24, 2019 01:40
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 24, 2019
@bgamari bgamari force-pushed the update-gitlab branch 3 times, most recently from 65430bb to c93baee Compare March 25, 2019 16:19
@flokli
Copy link
Contributor

flokli commented Mar 25, 2019

This seems to be mixed together with #57578.

Can you drop the commit?

What about gitlab-rails, which was added to nixos/modules/services/misc/gitlab.nix? I don't see it referenced anywhere, and wonder how this can be used…

@bgamari
Copy link
Contributor Author

bgamari commented Mar 25, 2019

@flokli, I've pushed a branch isolating the version bumps and have split out the gitlab-rails change into #58284.

@GrahamcOfBorg GrahamcOfBorg removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 25, 2019
@flokli flokli merged commit d402472 into NixOS:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz

@globin globin

@infinisil infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @flokli @GrahamcOfBorg