Skip to content

image_optim: init at 0.26.3 #57830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2019
Merged

image_optim: init at 0.26.3 #57830

merged 3 commits into from
Mar 26, 2019
+197 −0

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Mar 17, 2019 •
edited
Loading

Things done
# I have tested jpeg-archive
out=$(nix-build ./default.nix -A jpeg-archive)
$out/jpeg-archive --help # throws error, but it's should do so
$out/jpeg-compare --help
$out/jpeg-hash --help
$out/jpeg-recompress --help

# I have tested image_optim
sudo rm -rdf /tmp/test-images
mkdir -p /tmp/test-images
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/icecream.gif /tmp/test-images/icecream.gif
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/lena.jpg /tmp/test-images/lena.jpg
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/rails.png /tmp/test-images/rails.png
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/test.svg /tmp/test-images/test.svg
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/transparency1.png /tmp/test-images/transparency1.png
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/transparency2.png /tmp/test-images/transparency2.png
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/vergroessert.jpg /tmp/test-images/vergroessert.jpg
cd ~/projects/nixpkgs
out=$(nix-build ./default.nix -A image_optim)
(cd /tmp/test-images && $out/bin/image_optim --no-threads --verbose --allow-lossy --jpegoptim-allow-lossy true --jpegoptim-max-quality 85 --pngquant-allow-lossy true --pngquant-quality 0..85 -r .)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

have a question: can update bot execute update.sh or similar script to update packages and make pull request with the update?

Sorry, something went wrong.

@srghma srghma changed the title Image optim image_optim: init at 0.26.3 Mar 17, 2019
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 17, 2019
@joachifm
Copy link
Contributor

@GrahamcOfBorg build image_optim

@joachifm joachifm merged commit 8a2b572 into NixOS:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srghma @joachifm @GrahamcOfBorg