Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.{language-haskell,hie-server}: init #57829

Merged
merged 2 commits into from Mar 18, 2019
Merged

vscode-extensions.{language-haskell,hie-server}: init #57829

merged 2 commits into from Mar 18, 2019

Conversation

roberth
Copy link
Member

@roberth roberth commented Mar 17, 2019

Motivation for this change

These weren't available via Nixpkgs yet for declarative addition to VSCode.
I'm also packaging these extensions for home-manager, nix-community/home-manager#619

I've tried more than once to get something resembling a Haskell IDE, which usually ends with a half-broken setup. I'm happy to make the next Nix user's setup a bit easier.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth roberth changed the title Add VSCode extensions for Haskell vscode-extensions.{language-haskell,hie-server}: init Mar 17, 2019
@eadwu
Copy link
Member

eadwu commented Mar 18, 2019

Looks fine, verified hashes match.

worldofpeace
worldofpeace approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, we really need to get an update script for vscode extensions though.

@roberth roberth merged commit b3c0c2e into NixOS:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roberth @eadwu @worldofpeace @GrahamcOfBorg