Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.secretstorage: 3.1.0 -> 3.1.1 #57857

Merged
merged 1 commit into from Mar 18, 2019
Merged

pythonPackages.secretstorage: 3.1.0 -> 3.1.1 #57857

merged 1 commit into from Mar 18, 2019

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Mar 18, 2019 •
edited

Motivation for this change

Normal bump

Also fixes a pythonPackages.cryptography incompatibility.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb requested a review from FRidh as a code owner March 18, 2019 15:19
@srhb
Copy link
Contributor Author

srhb commented Mar 18, 2019

The only package that appears to depend on this that doesn't build after this change is bonfire, and that seems to be broken on master as well.

@dotlambda dotlambda changed the title pythonPackages.secretStorage: 3.1.0 -> 3.1.1 pythonPackages.secretstorage: 3.1.0 -> 3.1.1 Mar 18, 2019
@dotlambda
Copy link
Member

Also fixes a pythonPackages.cryptography incompatibility.

Does that mean this bump should be backported?

@srhb
Copy link
Contributor Author

srhb commented Mar 18, 2019

@dotlambda I've only seen it crop op in one place, and that's with the bugwarrior integration, but yes, I suppose that's sufficient to warrant a backport.

(Thanks for fixing the typo, I force pushed a fixed commit message as well)

@srhb
Copy link
Contributor Author

srhb commented Mar 18, 2019

Changelog says:

SecretStorage 3.1.1, 2019-01-24
===============================

 * Fixes TypeError with cryptography 2.5.
  Thanks Zach Hoffman for the pull request!

So yes, let's backport.

mitya57/secretstorage@a7fba9a

@dotlambda dotlambda merged commit 379ff38 into NixOS:master Mar 18, 2019
dotlambda pushed a commit that referenced this pull request Mar 18, 2019
@srhb
pythonPackages.secretstorage: 3.1.0 -> 3.1.1 (#57857)
7ec0f48 
(cherry picked from commit 379ff38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @dotlambda @GrahamcOfBorg