Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python36Packages.hpack: fix build #57808

Merged
merged 1 commit into from Mar 19, 2019
Merged

python36Packages.hpack: fix build #57808

merged 1 commit into from Mar 19, 2019

Conversation

alyssais
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested a review from FRidh as a code owner March 17, 2019 16:16
dotlambda
dotlambda reviewed Mar 17, 2019
View reviewed changes
pkgs/development/python-modules/hpack/default.nix Outdated
@@ -15,7 +15,7 @@ buildPythonPackage rec {

buildInputs = [ glibcLocales ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildInputs = [ glibcLocales ];
nativeBuildInputs = [ glibcLocales ];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really still needed for this package?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it is for python36.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I see the pr title includes python36Packages so that's where the failure is.

Perhaps it should just be conditioned for that interpreter version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a comment that it's for 3.6.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.hpack python36.pkgs.hpack python37.pkgs.hpack

@dotlambda
Copy link
Member

Actually, it seems like hpack builds just fine when no particular locale is set. So I'm removing that.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.hpack python36.pkgs.hpack python37.pkgs.hpack

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.hpack python36.pkgs.hpack python37.pkgs.hpack

@dotlambda dotlambda merged commit c357b53 into NixOS:master Mar 19, 2019
dotlambda pushed a commit that referenced this pull request Mar 19, 2019
@alyssais
python36Packages.hpack: fix build (#57808)
65fd49f 
(cherry picked from commit c357b53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @dotlambda @worldofpeace @GrahamcOfBorg