Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teleport: 2.4.1 -> 3.1.8 #57864

Merged
merged 1 commit into from Mar 22, 2019
Merged

teleport: 2.4.1 -> 3.1.8 #57864

merged 1 commit into from Mar 22, 2019

Conversation

tomberek
Copy link
Contributor

Motivation for this change

#57860

Things done

Updated version and SHA.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Really dislike how this application needs root to write to /var/lib.

@nlewo
Copy link
Member

nlewo commented Mar 21, 2019

@GrahamcOfBorg build teleport

@tomberek
Copy link
Contributor Author

@worldofpeace probably an issue for upstream or a service module. Or do you think it needs to be addressed in this packaging?

@worldofpeace
Copy link
Contributor

@worldofpeace probably an issue for upstream or a service module. Or do you think it needs to be addressed in this packaging?

homebrew has done something interesting https://github.com/Homebrew/homebrew-core/blob/master/Formula/teleport.rb

I don't think it resolves that issue completely, so maybe it should be left alone for now.
And yes service a module would improve this.

@worldofpeace worldofpeace merged commit e2ac456 into NixOS:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomberek @worldofpeace @nlewo @GrahamcOfBorg