Skip to content

[18.09] firefox 65.0.2 -> 66, 60.5.2esr -> 60.6.0esr, firefox-bin: 65.0.2 -> 66.0 #57861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 19, 2019
Merged

[18.09] firefox 65.0.2 -> 66, 60.5.2esr -> 60.6.0esr, firefox-bin: 65.0.2 -> 66.0 #57861

merged 6 commits into from
Mar 19, 2019
+448 −415

Conversation

andir
Copy link
Member

@andir andir commented Mar 18, 2019 •
edited
Loading

Motivation for this change

18.09 port of #56689

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

andir added 6 commits March 18, 2019 17:43
@andir
rustPlatform_1_31: init rustPlatform_1_31 attribute

Verified

This commit was signed with the committer’s verified signature.
codetheweb Max Isom
GPG key ID: C7631086E1E5F289
Verified
Learn about vigilant mode
a8e8de9 
rust_1_31 did exist already but the rustPlatform attrset was still
missing.
@andir
rust-cbindgen_0_8_0: init at 0.8.0

Verified

This commit was signed with the committer’s verified signature.
codetheweb Max Isom
GPG key ID: C7631086E1E5F289
Verified
Learn about vigilant mode
122a66d 
This is a requirement for Firefox66. To retain compatibility with users
of rust-cbindgen I leave the others around since it usually breaks some
kind of compatibility.
@andir
firefox: support building firefox 66 (and 60.6+)

Verified

This commit was signed with the committer’s verified signature.
codetheweb Max Isom
GPG key ID: C7631086E1E5F289
Verified
Learn about vigilant mode
5d17a76 
(cherry picked from commit d64d42f)
@andir
firefox: 65.0.2 -> 66.0

Verified

This commit was signed with the committer’s verified signature.
novemberborn Mark Wubben
SSH Key Fingerprint: vMGPTCc4s8qHvUbwn+BG4sx8ahyNN/1R52XsxINSNVk
Verified
Learn about vigilant mode
d4734ff 
(cherry picked from commit dafe9c3)
@andir
firefox-bin: 65.0.2 -> 66.0

Verified

This commit was signed with the committer’s verified signature.
codetheweb Max Isom
GPG key ID: C7631086E1E5F289
Verified
Learn about vigilant mode
d0f3ac2 
(cherry picked from commit a1cd934)
@andir
firefox-esr-60: 60.5.2esr -> 60.6.0.esr

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0021ea8 
(cherry picked from commit 94d9400)
@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Mar 18, 2019
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Mar 18, 2019
@andir andir merged commit 8751edf into NixOS:release-18.09 Mar 19, 2019
@andir andir deleted the 18.09/firefox66 branch March 19, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra

@jtojnar jtojnar

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @GrahamcOfBorg