Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file-rename: removed redundant packaging #57866

Closed
wants to merge 4 commits into from
Closed

file-rename: removed redundant packaging #57866

wants to merge 4 commits into from

Conversation

mkgvt
Copy link
Contributor

@mkgvt mkgvt commented Mar 18, 2019

Motivation for this change

The perl implementation of rename (file-rename) was packaged twice. Removing this one eliminates the redundancy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

The file removed is still referenced elsewhere, resulting in eval failure.

@mkgvt
Copy link
Contributor Author

mkgvt commented Apr 12, 2019

The file removed is still referenced elsewhere, resulting in eval failure.
Thanks for giving me a hint where to look. I am a novice at git (and NixOS for that matter). Pointers on how to address this?

@mkgvt
Copy link
Contributor Author

mkgvt commented Apr 12, 2019 via email

@jtojnar
Copy link
Contributor

jtojnar commented Apr 12, 2019

You can do git commit --amend when you want to add the changes to the last commit. Or you can create a separate commit and the use interactive rebase to combine (fixup) commits together. Then you can force push to your branch to overwrite this.

@joachifm
Copy link
Contributor

Hm, are these packages actually the same? Seems to me there are different upstreams, different authors, and different licenses. cc @peterhoeg as the maintainer of the other package.

@peterhoeg
Copy link
Member

Those are 2 different pieces of software as pointed out by @FRidh.

@peterhoeg peterhoeg closed this Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkgvt @joachifm @jtojnar @peterhoeg @mkgardner