Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[soundkonverter] init at 3.0.1 #57793

Merged
merged 1 commit into from Apr 27, 2019
Merged

[soundkonverter] init at 3.0.1 #57793

merged 1 commit into from Apr 27, 2019

Conversation

schmittlauch
Copy link
Member

@schmittlauch schmittlauch commented Mar 17, 2019 •
edited

Motivation for this change

initial packaging of the audio converter tool soundkonverter

Like many Qt and KDE applications, this needs to be installed into an environment and needs a run of kbuildsycoca5 afterwards for plugin discovery.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files after installing them into an environment
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch
Copy link
Member Author

Two things remain for this:

  1. audio playback (the preview function) does not work: WARNING: bool Phonon::FactoryPrivate::createBackend() phonon backend plugin could not be loaded
    I'm running the application under plasma, installed into a user environment, What might be problematic is the mix of release-18.09 and unstable packages. Any ideas on this, @ttuegel ?

  2. After installation, kbuildsycoca5 needs to be run for plugin discovery. Do I need to include something special for that?

@schmittlauch
Copy link
Member Author

I also welcome feedback on whether dependencies belong into buildInputs or propagatedBuildInputs

@schmittlauch schmittlauch changed the title [soundkonverter] init at 3.0.1 WIP: [soundkonverter] init at 3.0.1 Mar 17, 2019
@schmittlauch
Copy link
Member Author

just noticed an issue with the translation files location, changing status to WIP

@schmittlauch
Copy link
Member Author

@Mic92 What was your idea about translation filesfor KDE applications again? Right now they're located in /nix/store/28qq14yn0ywkxs3yyrns5qkfzy6hawm9-soundkonverter/share/locale/de/LC_MESSAGES/soundkonverter.mo, you mentioned moving them to $out/bin/ instead, right?

@Mic92
Copy link
Member

Mic92 commented Mar 22, 2019 •
edited

@schmittlauch I think the problem was that the binary is in $bin (which is not the same as $out/bin, but a different output of the package itself) while the locales are installed into $out. So maybe try to move both into the same output.

@Mic92
Copy link
Member

Mic92 commented Mar 22, 2019 •
edited

As you said offline to me, the translation file actually landed in the nix profile,
so the problem here is not about wrong outputs but soundkonverter not building the correct path, when looking for translation files.

@schmittlauch schmittlauch changed the title WIP: [soundkonverter] init at 3.0.1 [soundkonverter] init at 3.0.1 Mar 23, 2019
@schmittlauch
Copy link
Member Author

I'm afraid that the localization issues are just yet another instance of #37741. So let's ignore them for now and merge the package with English translations only.

@schmittlauch
Copy link
Member Author

as this is not WIP anymore: ping @ttuegel @Mic92

Ekleog
Ekleog approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. @Mic92, are you opposed to merging this with translations still failing? It does look like most of KDE is missing translations indeed, if I can trust #37741 (I'm not a KDE user myself)

pkgs/applications/audio/soundkonverter/default.nix Outdated Show resolved Hide resolved
@Mic92 Mic92 merged commit 4410646 into NixOS:master Apr 27, 2019
@schmittlauch schmittlauch mentioned this pull request Apr 29, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Ekleog approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schmittlauch @Mic92 @Ekleog @GrahamcOfBorg