Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fx_cast: init at 0.0.5 #57876

Merged
merged 7 commits into from Feb 20, 2020
Merged

fx_cast: init at 0.0.5 #57876

merged 7 commits into from Feb 20, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 18, 2019 •
edited

Motivation for this change

Still beta, but promising!
Used to cast netflix from firefox just now! :D

Fixes #54513.

Add config option to enable when using firefox (from source).
This doesn't work with firefox-bin,
as with other native-messaging-hosts browser extensions AFAIK,
but does work if you manually symlinks native-messaging-hosts
into something like ~/.mozilla/.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Mar 20, 2019

I don't have much use for this (no chromecast device) so I'm not the right person for a detailed review.

Why can't we build this from source?

@dtzWill
Copy link
Member Author

dtzWill commented Mar 21, 2019

Why can't we build this from source?

Because I'm not good with node packaging O:). Well, and because I made this trying to see if it'd work for me at all and how well-- so I was especially disinclined to invest in tackling a from-source build until had some idea :). But if anyone with good node-packaging-fu wants to give it a quick try that of course would be preferred! Especially given the kludgery needed to workaround the pkg'd bits.

@timokau
Copy link
Member

timokau commented Mar 21, 2019

Oh right, npm 🙄

@aanderse
Copy link
Member

ping (triage)

@domenkozar domenkozar self-assigned this Oct 16, 2019
@dtzWill dtzWill changed the title fx_cast: init at 0.0.3 fx_cast: init at 0.0.4 Nov 16, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Nov 16, 2019

Shame hasn't been release in a while (last is 0.0.4), which seems to have updates-- but using it would require building this ourselves so may be better waiting for release :).

@ryantm ryantm added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Jan 5, 2020
@bqv
Copy link
Contributor

bqv commented Feb 13, 2020

0.0.5 is now available

@dtzWill dtzWill changed the title fx_cast: init at 0.0.4 fx_cast: init at 0.0.5 Feb 14, 2020
@dtzWill
Copy link
Member Author

dtzWill commented Feb 14, 2020

0.0.5 is now available

Yep, pushed the bump :). Enjoy!

@domenkozar domenkozar merged commit 5f711b6 into NixOS:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau Awaiting requested review from timokau

@infinisil infinisil Awaiting requested review from infinisil

Assignees

@domenkozar domenkozar

Labels
2.status: wait-for-upstream Waiting for upstream fix (or their other action). 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: fx_cast
7 participants
@dtzWill @timokau @aanderse @bqv @ryantm @domenkozar @GrahamcOfBorg