Skip to content

nixos/datadog-agent: change start command #57871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2019
Merged

nixos/datadog-agent: change start command #57871

merged 1 commit into from
Mar 18, 2019
+1 −1

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Mar 18, 2019

Motivation for this change

Command "start" is deprecated

мар 18 22:18:21 mail.elven.pw systemd[1]: Stopping Datadog agent monitor...
мар 18 22:18:21 mail.elven.pw systemd[1]: Stopped Datadog agent monitor.
мар 18 22:18:21 mail.elven.pw systemd[1]: Starting Datadog agent monitor...
мар 18 22:18:21 mail.elven.pw systemd[1]: Started Datadog agent monitor.
мар 18 22:18:21 mail.elven.pw sc5hvpws8sykrl453krxba8y8zvxphln-unit-script-datadog-agent-start[6164]: Command "start" is deprecated, Use "run" instead to start the Agent
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Izorkin Izorkin requested a review from infinisil as a code owner March 18, 2019 19:19
@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 18, 2019

cc @kalbasit

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 18, 2019
@kalbasit
Copy link
Member

This is confirmed by looking at the source code as well: https://github.com/DataDog/datadog-agent/blob/0c8aee4b9cd2d64a935d095c9e8addffdd463079/cmd/agent/app/start.go#L70-L72

@kalbasit kalbasit merged commit f56d507 into NixOS:master Mar 18, 2019
@kalbasit
Copy link
Member

Thanks @Izorkin

@Izorkin Izorkin deleted the datadog-agent-config branch March 19, 2019 06:49
domenkozar pushed a commit that referenced this pull request Apr 18, 2019
@Izorkin @domenkozar
nixos/datadog-agent: change start command (#57871)
7990c3e 
(cherry picked from commit f56d507)
Signed-off-by: Domen Kožar <domen@dev.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @kalbasit @GrahamcOfBorg