Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] haskellPackages.arbtt: 0.10.1 -> 0.10.2 #57874

Merged
merged 1 commit into from Mar 23, 2019
Merged

[19.03] haskellPackages.arbtt: 0.10.1 -> 0.10.2 #57874

merged 1 commit into from Mar 23, 2019

Conversation

erictapen
Copy link
Member

Motivation for this change

This is a partial backport of e98e4d2 and 7c04e3e to make arbtt build again.

Continuation of #57585

Things done

Also I took care, that upgrading hackage-packages.nix will result in a build failure of arbtt, as the upgrade should not be silently overwritten. If I see this right, hackage-packages.nix should not be upgraded on release-19.03 anyway.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.arbtt

@erictapen erictapen changed the title [release-19.03] haskellPackages.arbtt: 0.10.1 -> 0.10.2 [19.03] haskellPackages.arbtt: 0.10.1 -> 0.10.2 Mar 20, 2019
@erictapen
haskellPackages.arbtt: 0.10.1 -> 0.10.2
31a5868 
This is a backport of e98e4d2 and
7c04e3e to make arbtt build again.
@erictapen
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.arbtt

@peti peti merged commit 6bbde4c into NixOS:release-19.03 Mar 23, 2019
@erictapen erictapen deleted the arbtt-0.10.2 branch March 24, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @peti @GrahamcOfBorg