Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers-list.nix: added "growpotkin" #57875

Closed
wants to merge 1 commit into from
Closed

maintainers-list.nix: added "growpotkin" #57875

wants to merge 1 commit into from

Conversation

aakropotkin
Copy link
Contributor

Adding myself to maintainers list, hopefully my commit message is okay.

Motivation for this change

To list myself on package submissions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aakropotkin
maintainers-list.nix: added "growpotkin"
2d849a3 
Adding myself to maintainers list, hopefully my commit message is okay.
@xeji
Copy link
Contributor

xeji commented Mar 18, 2019

Thank you for your interest in contributing to our project!

We prefer to add people to the maintainers list when they first volunteer to maintain of a specific package (new or existing). There's no need to do this in advance, and there's no formal confirmation process either.

So may I kindly ask you to resubmit this change at a later time together with a PR that makes you maintainer of (at least) one specific package. Thank you.

@xeji xeji closed this Mar 18, 2019
@aakropotkin
Copy link
Contributor Author

Totally understand. I meant to add this to my existing merge request for a packaged I added and plan to maintain.

@aakropotkin
Copy link
Contributor Author

#57872
ecdsatools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aakropotkin @xeji @GrahamcOfBorg