Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] gxi: init at 0.5.5 #57878

Closed
wants to merge 1 commit into from
Closed

[WIP] gxi: init at 0.5.5 #57878

wants to merge 1 commit into from

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Mar 18, 2019

Motivation for this change

Package all the things!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jansol
Copy link
Contributor Author

jansol commented Mar 18, 2019

Ugh, looks like DESTDIR=$out was not correct after all, fixing...

@jansol jansol changed the title gxi: init at 0.5.5 [WIP] gxi: init at 0.5.5 Mar 18, 2019
@dtzWill
Copy link
Member

dtzWill commented Mar 18, 2019

This seems to have a duplicate "prefix", result/nix/store/xxx..../bin/gxi vs result/bin/gxi? I'm trying a build w/o setting DESTDIR to see if that fixes things, not sure. (EDIT: sorry was using outdated info, this appears resolved now)

FWIW, previously: #48593 .
Which I was encouraged to make available elsewhere until xi was more "stable".
Accordingly, may want to check out my NUR repo: https://github.com/dtzWill/nur-packages/,
particularly: https://github.com/dtzWill/nur-packages/tree/master/pkgs/xi and especially https://github.com/dtzWill/nur-packages/blob/master/pkgs/xi/gxi/default.nix .

I would be happy to see this (and perhaps others) in nixpkgs proper, or otherwise improved and made available for folks to explore!

There might be better ways to approach this than what I did, but it does handle something I don't think is tackled here: rigging up the xi-syntext plugin so that syntax highlighting works out-of-the-box.
(You still need to select filetype from the drop-down, but it otherwise seems to work! Well, other than the unforgivable (:wink:) omission of highlight support for Nix files!

I haven't poked at this much recently (beyond automated updates), but offhand it might be better for gxi in particular to do something more like what you have done re:all-in-one to avoid mismatches between frontend and backend versions. Although I forget if that's a concern 😇.

@dtzWill
Copy link
Member

dtzWill commented Mar 18, 2019

Oh the syntect plugin is handled here now too, great! That was the main technical point, glad it's handled automagically.

@jansol
Copy link
Contributor Author

jansol commented Mar 18, 2019

Yeah I noticed that problem. I'm setting DESTDIR precisely because the meson postinstall script was failing otherwise. Still no clue why, it wouldn't print out anything...

This was just a mostly clueless attempt at packaging gxi so I don't have to use atom. Anyway this does set up xi-syntect-plugin. Your setup seems to allow for much better sharing of derivations down the line though so I'd probably prefer that route. Would be nice to be able to use a shared LSP plugin installation for all xi frontends. Plugins and frontends AFAIK should not be tied to any specific core version, but until 1.0 there are of course no guarantees about that.

TIL about NUR. I guess I'll just close this until we figure out a proper clean setup...

@jansol jansol closed this Mar 18, 2019
@jansol
Copy link
Contributor Author

jansol commented Mar 18, 2019

Let's move discussion to the xi-editor Zulip instance.

@Cogitri Cogitri mentioned this pull request Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants