Fix FreeCAD build 19.03 #57879
Fix FreeCAD build 19.03 #57879
Conversation
|
Fixes should typically go to master first, and then cherry-picked (with |
That certainly was my intention. Is something missing? |
| @@ -16,8 +16,12 @@ buildPythonPackage rec { | |||
| sha256 = "18n14ha2d3j3ghg2f2aqnf2mks94nn7ma9ii7vkiwcay93zm82cf"; | |||
| }; | |||
|
|
|||
| nativeBuildInputs = with pkgs; [ | |||
| swig1 coin3d soqt | |||
There was a problem hiding this comment.
You're sure these should only be native? Did you actually try using pivy?
There was a problem hiding this comment.
No, not sure. I tested compilation and running FreeCAD. I don't know how to test, from within FreeCAD, that the coin3d library is called correctly. Should I add it to buildInputs too, to be on the safe side?
There was a problem hiding this comment.
My intuition is that both, coin3d and soqt, don't belong into nativeBuildInputs but buildInputs. If that works, I guess we can leave it as is.
However, we should eventually bring pivy up to date and maybe try running the tests as in https://github.com/FreeCAD/pivy/blob/0.6.4/.travis.yml#L20.
There was a problem hiding this comment.
Well, they were there, until b4acd97 specifically set strictDeps to true, but states that compile/runtime deps belong to buildInputs. These two things seem to be opposed to each other, though, since this has the effect of CFLAGS not
including the buildInputs dependencies anymore. Equally probable that I misunderstood the whole thing, though.
TLDR: no idea, really.
Note that there is another WIP PR (see description) which deals with bringing pivy and everything else up-to-date.
There was a problem hiding this comment.
Afaik, swig is only used at build time whereas the other two are runtime dependencies. Hence coin3d and soqt should definitely be in buildInputs. After looking at this further I think it is required to also put them in nativeBuildInputs because coin-config soqt-config are called at build time.
timor
force-pushed
the
fix-freecad-build-19.03
branch
from
f07d878 to
6202e00
Compare
|
@GrahamcOfBorg build python2.pkgs.pivy python3.pkgs.pivy python2.pkgs.pyside-tools python3.pkgs.pyside-tools |
|
@GrahamcOfBorg build python2.pkgs.pivy python2.pkgs.pysideTools python3.pkgs.pysideTools |
dotlambda
added
the
9.needs: port to stable
timor
force-pushed
the
fix-freecad-build-19.03
branch
from
6202e00 to
de1634a
Compare
Right, thanks! Changed the messages. |
|
@GrahamcOfBorg build python2.pkgs.pivy python2.pkgs.pysideTools python3.pkgs.pysideTools |
|
@timor Thanks a lot! |
samueldr
removed
the
9.needs: port to stable
Motivation for this change
Some dependencies of FreeCAD have not been building since a recent change to
buildPythonPackage. This fixes the python modules necessary for FreeCAD, which should help with#56826
This PR is only intended to fix the build for 19.03. There is another PRs which additionally updates a bunch of dependencies (#57121), that should be pulled in in the long run.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)