[19.03] python.pkgs.distro: Re-enable the package #57877
Merged
+40
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most tests are fine (only 20 out of 173 fail, 10 because lsb_release is not available or returns exit code 3 and the other 10 might also fail due to the sandboxed build environment). Manual tests show that distro works as intended in a normal environment. See NixOS@9382d2e (cherry picked from commit 871cd75) Reason: The package works as expected outside of the build sandbox and the packages google-cloud-sdk-gce and google-compute-engine depend on it (and soon also gns3-gui and gns3-server).
GrahamcOfBorg
added
6.topic: nixos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most tests are fine (only 20 out of 173 fail, 10 because lsb_release is
not available or returns exit code 3 and the other 10 might also fail
due to the sandboxed build environment).
Manual tests show that distro works as intended in a normal environment.
See 9382d2e
(cherry picked from commit 871cd75)
Reason: The package works as expected outside of the build sandbox and
the packages google-cloud-sdk-gce and google-compute-engine depend on it
(and soon also gns3-gui and gns3-server).