buildGoModule: backport the new Go infrastructure to release 19.03 #57805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves buildGoPackage from pkgs/development/go-modules to pkgs/development/go-packages, so we can have buildGoModule at pkgs/development/go-modules. (cherry picked from commit a0d835e)
The function buildGoModule builds Go programs managed with Go modules. It builds a Go module through a two phase build: - An intermediate fetcher derivation. This derivation will be used to fetch all of the dependencies of the Go module. - A final derivation will use the output of the intermediate derivation to build the binaries and produce the final output. (cherry picked from commit 28435e4)
|
@GrahamcOfBorg build jx pet hugo gotools terminal-parrot todoist hetzner-kube mod |
|
Why would we need to backport this? It's a breaking change that AFAIU doesn't fix any major functionality or security bugs. |
|
@lheckemann it's not a breaking change, but instead a new feature. It does make packaging Go modules a lot easier than it currently is. The legacy |
|
@kalbasit for the backport it might be better to skip migration of existing packages and only backport the function/documentation itself. |
(cherry picked from commit 832eb25)
kalbasit
force-pushed
the
nixpkgs_backport-build-go-module
branch
from
a339da7
to
a456b83
Compare
|
@Mic92 sure, I've rebased my pull request and left only commits directly related to |
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This pull request backports #57080 into release 19.03. #57080 provides a new infrastructure for packaging Go modules without the need to manually package the dependencies. It relies instead on Go's module reproducibility and versioning to compute the dependencies in the early stage of the build.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @NixOS/backports