Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lynx: enable default-colors #57803

Merged
merged 1 commit into from Jun 2, 2019
Merged

lynx: enable default-colors #57803

merged 1 commit into from Jun 2, 2019

Conversation

alyssais
Copy link
Member

Motivation for this change

Building with this option allows Lynx to optionally use the default colors of the terminal, when compiled with ncurses or slang. It does not (as far as I know) change any default behavior.

Since we build with ncurses, I don't think there's any reason not to have this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Building with this option allows Lynx to optionally use the default
colors of the terminal, when compiled with ncurses or slang. It does not
(as far as I know) change any default behavior.

Since we build with ncurses, I don't think there's any reason not to
have this.
@Yarny0
Copy link
Contributor

Yarny0 commented May 12, 2019

Reviewed points
  • package name fits guidelines (no change)
  • package version fits guidelines (no change)
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • all depending packages build

Notes on testing:

  • Tested after rebasing onto current nixos-unstable channel (bc94dcf). Compared behaviour with lynx from current nixos-19.03.
  • Opened https://en.wikipedia.org: With the executable from this pull request, the page looks like it looks with lynx from current nixos-19.03 channel. In particular, the colors have not changed.
  • Opened https://en.wikipedia.org with and without -default_colors lynx command line option. With the option added, colors look more dim on my konsole terminal emulator, so the option apparently has an effect.
Comments
  • There isn't much documentation (neither man page nor internet) about the default-colors option. From my observation, it has effects, but no negative effects. I can't judge if it is actually doing what it is supposed to do.
  • Nevertheless, I can't see a problem with enabling this option.
  • The lynx package has no maintainers. Notifying those that modified it recently: @dtzWill @jfrankenau
  • I'm surprised that this change provokes so many rebuilds ("101-500"). lynx seems to be the base of a lot of other packages. From just grepping for "lynx" in <nixpkgs/pkgs> I get the vague impression that depending packages just use lynx to show some html to the user. If there are any users with a more involved usage (if lynx supports more at all), those packages should probably be checked more closely.

@alyssais alyssais merged commit 45f4cc1 into NixOS:master Jun 2, 2019
@alyssais alyssais deleted the lynx branch June 2, 2019 19:17
@alyssais
Copy link
Member Author

alyssais commented Jun 2, 2019

Thanks for the review @Yarny0. :) Looks like this is uncontroversial enough we can try it out in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants