Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wikidpad: init at WikidPad-2-3-beta13_01 #57835

Closed
wants to merge 1 commit into from
Closed

Wikidpad: init at WikidPad-2-3-beta13_01 #57835

wants to merge 1 commit into from

Conversation

deliciouslytyped
Copy link
Contributor

@deliciouslytyped deliciouslytyped commented Mar 18, 2019 •
edited

#55681
Edit: superseded by Superseded by #55681, will close after merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Mar 18, 2019

Would it make sense to use newer 2.3 release, such as rc2?

@deliciouslytyped
Copy link
Contributor Author

deliciouslytyped commented Mar 18, 2019 •
edited

I don't really know. I just grabbed the first thing that wasn't marked as pre-release: https://github.com/WikidPad/WikidPad/releases.

I guess I should also add a reference to the github page somewhere in here.

ryantm
ryantm requested changes Jan 5, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it would be good to rename the file to default.nix like usual.

pkgs/applications/office/wikidpad/2.3.nix
python = (python27.withPackages (p: with p; [ wxPython ]));
in
stdenv.mkDerivation {
name = "wikidpad-${rev}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "wikidpad-${rev}";
pname = "wikidpad";

pkgs/applications/office/wikidpad/2.3.nix

{stdenv, lib, fetchFromGitHub, python27, makeWrapper, wrapGAppsHook}:
let
fetchGitHubJSON = file: fetchFromGitHub { inherit (lib.importJSON file) owner repo rev sha256; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, it seems excessive to have this JSON file and all this extra machinery to fetch the source when we are only getting one revision. Can we make this just be a normal fetchFromGitHub, like most of nixpkgs?

pkgs/applications/office/wikidpad/2.3.nix
'';
homepage = "http://wikidpad.sourceforge.net/";
license = with lib.licenses; [ bsd2 asl20 ];
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself as a maintainer in a separate commit.

@stale
Copy link

stale bot commented Jul 3, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 3, 2020
@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 29, 2020 01:58
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 29, 2020
@stale
Copy link

stale bot commented Jun 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2021
@Artturin Artturin closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deliciouslytyped @dtzWill @ryantm @GrahamcOfBorg @Artturin