Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/security: make duo support secure failure correctly #57836

Merged
merged 1 commit into from Mar 27, 2019
Merged

nixos/security: make duo support secure failure correctly #57836

merged 1 commit into from Mar 27, 2019

Conversation

reanimus
Copy link
Contributor

Motivation for this change

Duo currently doesn't properly support secure failure, as the enum is incorrectly created without the secure option in it. This adds it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@reanimus
nixos/security: make duo support secure failure correctly
0c34b9f 
seems that this got broken when the config option was made to use enums. "secure" got replaced with "enum", which isn't a valid option for the failure mode.
@infinisil infinisil merged commit 8471ab7 into NixOS:master Mar 27, 2019
@infinisil
Copy link
Member

Backported to 19.03 in 02cd553
Backported to 18.09 in 38e0576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reanimus @infinisil @GrahamcOfBorg @Janik-Haag