Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zsh: enable configure history and custom options #57856

Merged
merged 1 commit into from Mar 20, 2019
Merged

nixos/zsh: enable configure history and custom options #57856

merged 1 commit into from Mar 20, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Mar 18, 2019 •
edited

Motivation for this change

Allow changing history parameters and zsh options.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin requested a review from infinisil as a code owner March 18, 2019 14:10
@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 18, 2019

Changed config to new variant.
cc @Mic92 @infinisil @grahamc

Mic92
Mic92 reviewed Mar 18, 2019
View reviewed changes
nixos/modules/programs/zsh/zsh.nix
HISTSIZE=2000
HISTFILE=$HOME/.zsh_history
export SAVEHIST=${toString cfg.histSize}
export HISTSIZE=${toString cfg.histSize}
Copy link
Member

@Mic92 Mic92 Mar 18, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that zsh sometimes truncates the history if SAVEHIST is set to a value like 2000, even if the user later sets a larger value for example in interactiveShellInit below?
Because I sometimes miss old entries.

Copy link
Contributor Author

@Izorkin Izorkin Mar 18, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how zsh behaves in this case. Zsh has the HIST_EXPIRE_DUPS_FIRST option, which removes duplicates when limit is exceeded. I normally put HISTSIZE=1000000 and HISTFILESIZE=$HISTSIZE in interactiveShellInit, and it was always enough

@disassembler disassembler merged commit 4399361 into NixOS:master Mar 20, 2019
@Izorkin Izorkin deleted the zsh-options branch March 20, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@disassembler disassembler disassembler approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @Mic92 @disassembler @GrahamcOfBorg