Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngrok-2: 2.2.8 -> 2.3.18 #57827

Closed
wants to merge 1 commit into from
Closed

ngrok-2: 2.2.8 -> 2.3.18 #57827

wants to merge 1 commit into from

Conversation

bobvanderlinden
Copy link
Member

Motivation for this change

Get ngrok-2 up to date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth
Copy link
Member

roberth commented Mar 17, 2019

I've tried that and it didn't work. Here's my automation + immutable urls #57536. What do you think?

@roberth
Copy link
Member

roberth commented Mar 17, 2019

Sorry, forgot to @ you :(

@bobvanderlinden
Copy link
Member Author

Which part did not work?

Apart from that, thanks a lot for the automation. Much appreciated! I'll close this out in the of yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobvanderlinden @roberth @GrahamcOfBorg