Skip to content

anbox: init at 2019-03-07 #57826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 22, 2019
Merged

anbox: init at 2019-03-07 #57826

merged 4 commits into from
Mar 22, 2019
+348 −0

Conversation

gebner
Copy link
Member

@gebner gebner commented Mar 17, 2019

Motivation for this change

Android in a box

This is an update of @edwtjo's PR #48040. Now networking works out of the box---I just had to enable NAT, networking works even though adb shell ip r doesn't show a default route.

For testing, I'm starting anbox session-manager and then anbox-application-manager.

cc @edwtjo @Mic92 @jasoncarr0 @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@gebner gebner requested a review from infinisil as a code owner March 17, 2019 18:56
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package labels Mar 17, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from edwtjo March 17, 2019 19:12
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Mar 17, 2019
@dtzWill
Copy link
Member

dtzWill commented Mar 18, 2019

Is there a reason to not use gtest? Cursory glance suggests it's the same source.

edwtjo and others added 4 commits March 18, 2019 09:23
@edwtjo @Mic92 @gebner
linuxPackages.anbox: init at 2018-09-08
dfa314c 
Co-authored-by: Luke Adams <luke.adams@belljar.io>
Co-authored-by: Volth <volth@webmaster.ms>
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
Co-authored-by: Edward Tjörnhammar <ed@cflags.cc>
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
@edwtjo @Mic92 @gebner
properties-cpp: init at 0.0.1
07632cb 
Co-authored-by: Luke Adams <luke.adams@belljar.io>
Co-authored-by: Volth <volth@webmaster.ms>
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
@edwtjo @Mic92 @gebner
anbox: init at 2019-03-07
e42b5d9 
Co-authored-by: Luke Adams <luke.adams@belljar.io>
Co-authored-by: Volth <volth@webmaster.ms>
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
Co-authored-by: Edward Tjörnhammar <ed@cflags.cc>
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
@edwtjo @Mic92 @gebner
nixos/anbox: init module
0f03f28 
Co-authored-by: Luke Adams <luke.adams@belljar.io>
Co-authored-by: Volth <volth@webmaster.ms>
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
Co-authored-by: Edward Tjörnhammar <ed@cflags.cc>
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
@gebner
Copy link
Member Author

gebner commented Mar 18, 2019

@dtzWill Good point. It requires a fair amount of patching in the cmake code but it's doable. Upstream includes googletest as a cmake external project, which expects the googletest source code.

Mic92
Mic92 approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the previous PR, since there are no significant changes here, I assume it should be fine.

@Mic92
Copy link
Member

Mic92 commented Mar 19, 2019 •
edited
Loading

If anbox works like Android the routing tables for the default route should be in other routing tables then main. Just use adb shell ip rule to list them and then adb shell ip route show table <table>.

@gebner
Copy link
Member Author

gebner commented Mar 22, 2019

@Mic92 I would have never found that. ip r s t 0 shows indeed that the default route is set up correctly.

@gebner gebner merged commit 03f7c82 into NixOS:master Mar 22, 2019
@gebner gebner mentioned this pull request Mar 22, 2019
Closed
9 tasks
@worldofpeace worldofpeace mentioned this pull request Mar 22, 2019
Merged
10 tasks
@zarelit
Copy link
Member

zarelit commented Mar 23, 2019

🎉

@Mic92
Copy link
Member

Mic92 commented Mar 25, 2019 •
edited
Loading

@gebner Yeah source routing policies is a not-well known corner of the Linux networking stack. It comes right in terms of weirdness right after tc.

@worldofpeace worldofpeace mentioned this pull request Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@infinisil infinisil

@edwtjo edwtjo

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gebner @dtzWill @Mic92 @zarelit @GrahamcOfBorg @edwtjo