anbox: init at 2019-03-07 #57826
Merged
anbox: init at 2019-03-07 #57826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason to not use |
Co-authored-by: Luke Adams <luke.adams@belljar.io> Co-authored-by: Volth <volth@webmaster.ms> Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com> Co-authored-by: Edward Tjörnhammar <ed@cflags.cc> Co-authored-by: Gabriel Ebner <gebner@gebner.org>
Co-authored-by: Luke Adams <luke.adams@belljar.io> Co-authored-by: Volth <volth@webmaster.ms> Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
Co-authored-by: Luke Adams <luke.adams@belljar.io> Co-authored-by: Volth <volth@webmaster.ms> Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com> Co-authored-by: Edward Tjörnhammar <ed@cflags.cc> Co-authored-by: Gabriel Ebner <gebner@gebner.org>
Co-authored-by: Luke Adams <luke.adams@belljar.io> Co-authored-by: Volth <volth@webmaster.ms> Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com> Co-authored-by: Edward Tjörnhammar <ed@cflags.cc> Co-authored-by: Gabriel Ebner <gebner@gebner.org>
|
@dtzWill Good point. It requires a fair amount of patching in the cmake code but it's doable. Upstream includes googletest as a cmake external project, which expects the googletest source code. |
Mic92
approved these changes
Mar 19, 2019
|
If anbox works like Android the routing tables for the default route should be in other routing tables then |
|
@Mic92 I would have never found that. |
|
🎉 |
|
@gebner Yeah source routing policies is a not-well known corner of the Linux networking stack. It comes right in terms of weirdness right after tc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Android in a box
This is an update of @edwtjo's PR #48040. Now networking works out of the box---I just had to enable NAT, networking works even though
adb shell ip rdoesn't show a default route.For testing, I'm starting
anbox session-managerand thenanbox-application-manager.cc @edwtjo @Mic92 @jasoncarr0 @peterhoeg
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)