Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcompare: init at 4.2.10.23938 #62708

Merged
merged 2 commits into from Aug 24, 2019
Merged

bcompare: init at 4.2.10.23938 #62708

merged 2 commits into from Aug 24, 2019

Conversation

ktor
Copy link
Member

@ktor ktor commented Jun 4, 2019 •
edited

Motivation for this change

I was missing Beyond Compare merge/diff application in the repo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notes

This is initial commit. App works on my NixOS machine with xmonad. I have not tested it with other windows managers.

@ktor
Copy link
Member Author

ktor commented Jun 6, 2019

Hi @JohnAZoidberg , I've added all changes you've suggested. Thank you!

@ktor
Copy link
Member Author

ktor commented Jun 23, 2019

I've squashed all the improvement commits into one.

worldofpeace
worldofpeace suggested changes Jul 29, 2019
View reviewed changes
pkgs/applications/version-management/bcompare/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/bcompare/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/bcompare/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/bcompare/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/bcompare/default.nix Show resolved Hide resolved
pkgs/applications/version-management/bcompare/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/bcompare/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/bcompare/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
@ktor ktor force-pushed the bcompare-4.2.10.23938 branch 2 times, most recently from 199004d to a2329b2 Compare July 30, 2019 20:19
@ktor
Copy link
Member Author

ktor commented Jul 30, 2019

@worldofpeace - all done. Thank you for review!

@worldofpeace
Copy link
Contributor

@ktor #62708 (comment)

@ktor ktor force-pushed the bcompare-4.2.10.23938 branch 2 times, most recently from 044b10d to 5f47444 Compare August 23, 2019 16:15
@ktor
Copy link
Member Author

ktor commented Aug 24, 2019

@worldofpeace all done, thx!

@worldofpeace worldofpeace merged commit a980a2c into NixOS:master Aug 24, 2019
@worldofpeace
Copy link
Contributor

Thanks for contributing @ktor ✨

@ktor ktor deleted the bcompare-4.2.10.23938 branch October 13, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@JohnAZoidberg JohnAZoidberg JohnAZoidberg requested changes

Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ktor @worldofpeace @JohnAZoidberg @Janik-Haag