Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asciidoctor: 1.5.7.1 -> 2.0.10 #62707

Merged
merged 1 commit into from Jun 12, 2019
Merged

asciidoctor: 1.5.7.1 -> 2.0.10 #62707

merged 1 commit into from Jun 12, 2019

Conversation

michaelpj
Copy link
Contributor

Motivation for this change

There has been a new major version, so it seems good to upgrade.

I had to drop two plugins:

  • asciidoctor-latex seems dead, and hasn't had any commits since 2015.
  • asciidoctor-bespoke also hasn't been updated for over a year, and
    doesn't seem to be compatible with the new version.

@yacinehmito

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

commit msg should be

asciidoctor: 1.5.7.1 -> 2.0.10

@michaelpj
asciidoctor: 1.5.7.1 -> 2.0.10
3d1e0da 
There has been a new major version, so it seems good to upgrade.

I had to drop two plugins:
- `asciidoctor-latex` seems dead, and hasn't had any commits since 2015.
- `asciidoctor-bespoke` also hasn't been updated for over a year, and
doesn't seem to be compatible with the new version.
@michaelpj
Copy link
Contributor Author

Commit message fixed.

yacinehmito
yacinehmito approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@yacinehmito yacinehmito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested (not running a NixOS system currently) but it LGTM 👍 .

Also, small question: why did you remove asciidoctor-latex?

@michaelpj
Copy link
Contributor Author

Also, small question: why did you remove asciidoctor-latex?

Ah, I said why I didn't feel bad about dropping it, but not why I had to: it specifies an old version of asciidoctor in its gemspec. I don't know if there's a way to override it's version constraints, but I couldn't get bundix to work for me with it included. Also, I think the internals of asciidoctor changed a fair bit in 2.0, which is likely to affect plugins that aren't explicitly updated.

@worldofpeace worldofpeace changed the title asciidoctor: update to 2.0.10 asciidoctor: 1.5.7.1 -> 2.0.10 Jun 5, 2019
@worldofpeace
Copy link
Contributor

Looks good to me, is there someway I can use this nix expression to run their tests?

@michaelpj
Copy link
Contributor Author

No obviously. I tried installing rake and using nix-shell on it, but it didn't work. Nor does it have an .env attribute as the manual says it should...

@FRidh FRidh added this to the 19.09 milestone Jun 9, 2019
@worldofpeace
Copy link
Contributor

I tried installing rake and using nix-shell on it, but it didn't work. Nor does it have an .env attribute as the manual says it should...

Looks like that's WIP being fixed #62971 ✨

@michaelpj
Copy link
Contributor Author

Do you want to wait to try that out or can we merge this? I've tested the executables by hand and they seem to work.

@worldofpeace
Copy link
Contributor

That sounds fine, merging now.

@worldofpeace worldofpeace merged commit 17d0fc2 into NixOS:master Jun 12, 2019
@danbst danbst mentioned this pull request Jun 26, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacinehmito yacinehmito yacinehmito approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaelpj @worldofpeace @yacinehmito @FRidh