Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/zoneminder: font files cannot be found #62758

Merged
merged 1 commit into from Jun 8, 2019
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

ZM's paths to font files are wrong so we need to rewrite them.

The browser will try to access /skins/classic/css/fonts/font_file.ttf which should just be /fonts/font_file.ttf.

I have no idea how this used to work, but in any case after this it does.

Cc: @amazari @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straight forward. LGTM 👍

@srhb srhb merged commit 635e3b1 into NixOS:master Jun 8, 2019
@peterhoeg peterhoeg deleted the f/zm branch June 9, 2019 03:21
@peterhoeg peterhoeg restored the f/zm branch June 9, 2019 07:50
@peterhoeg peterhoeg deleted the f/zm branch June 14, 2019 01:52
@peterhoeg peterhoeg restored the f/zm branch June 14, 2019 12:27
@peterhoeg peterhoeg deleted the f/zm branch June 20, 2019 09:30
@peterhoeg peterhoeg restored the f/zm branch June 20, 2019 12:04
@peterhoeg peterhoeg deleted the f/zm branch June 26, 2019 02:51
@peterhoeg peterhoeg restored the f/zm branch June 27, 2019 05:20
@peterhoeg peterhoeg deleted the f/zm branch July 3, 2019 10:29
@peterhoeg peterhoeg restored the f/zm branch July 4, 2019 01:22
@peterhoeg peterhoeg deleted the f/zm branch July 16, 2019 23:43
@peterhoeg peterhoeg restored the f/zm branch July 18, 2019 01:27
@peterhoeg peterhoeg deleted the f/zm branch July 24, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants