Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagecodecs-lite: init at 2019.4.20 #62754

Merged
merged 1 commit into from Sep 5, 2019
Merged

imagecodecs-lite: init at 2019.4.20 #62754

merged 1 commit into from Sep 5, 2019

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented Jun 6, 2019

Motivation for this change

Block-oriented, in-memory buffer transformation, compression, and decompression functions. Needed for tifffile

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tbenst tbenst requested a review from FRidh as a code owner June 6, 2019 05:34
@tbenst tbenst mentioned this pull request Jun 6, 2019
Closed
10 tasks
@tbenst tbenst closed this Jun 6, 2019
@tbenst tbenst reopened this Jun 26, 2019
@tbenst
Copy link
Contributor Author

tbenst commented Jun 30, 2019

@FRidh ok to merge? #62755 should be all set afterwards, too

@aanderse
Copy link
Member

aanderse commented Sep 1, 2019 •
edited

@GrahamcOfBorg build python2Packages.imagecodecs-lite python3Packages.imagecodecs-lite

@aanderse
Copy link
Member

aanderse commented Sep 1, 2019

@tbenst maybe you can take a look at the failures when you get a chance.

@tbenst
Copy link
Contributor Author

tbenst commented Sep 1, 2019

@aanderse happy to, what failures are you referring to?

@aanderse
Copy link
Member

aanderse commented Sep 1, 2019

If I look at the checks tab the bot lists all tests run as failed.

@tbenst
Copy link
Contributor Author

tbenst commented Sep 4, 2019

@aanderse python3 builds, python2 fails. I don't code with python2 and am not particularly motivated to fix given python 2 EOL in four months. I seem to recall there being a way to mark as python3 only? Couldn't find in a quick search of nixpkg manual / github

@aanderse
Copy link
Member

aanderse commented Sep 4, 2019

@tbenst sounds like a solid plan.

mailman = disabledIf (!isPy3k) (callPackage ../servers/mail/mailman/core.nix { });

@tbenst
Copy link
Contributor Author

tbenst commented Sep 5, 2019

@aanderse done!

@aanderse aanderse mentioned this pull request Sep 5, 2019
Merged
9 tasks
aanderse
aanderse requested changes Sep 5, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a look at the actual code now and have 2 minor nitpicks for you to address please. After that we're good to merge 👍

pkgs/development/python-modules/imagecodecs-lite/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/imagecodecs-lite/default.nix Outdated Show resolved Hide resolved
@tbenst
Copy link
Contributor Author

tbenst commented Sep 5, 2019

done, thx!

@aanderse
Copy link
Member

aanderse commented Sep 5, 2019

@GrahamcOfBorg build python3Packages.imagecodecs-lite

@aanderse aanderse merged commit 34a6f75 into NixOS:master Sep 5, 2019
@tbenst tbenst mentioned this pull request Dec 22, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbenst @aanderse