Handle SIGWINCH in main thread #2921
Merged
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the SIGWINCH signal to be caught, it needs to be set in sigaction on the main thread. Previously, this was broken, and updateWindowSize was never being called. Tested on macOS 10.14.
|
How does this interact with the signal handler thread, which is supposed to handle SIGWINCH? It's also not clear to me how installing a signal handler that does nothing causes |
|
Ah it looks like this only matter in macOS. On Linux the behavior is correct. I'll need to investigate what is actually going on. I suspect something is broken on macOS pthread_sigmask. |
|
This example program works on Linux but not macOS: #include <stdio.h>
#include <stdlib.h>
#include <pthread.h>
#include <signal.h>
#include <string.h>
#include <errno.h>
static sigset_t signal_mask;
void *signal_thread(void *arg) {
int sig_caught;
while (1) {
sigwait(&signal_mask, &sig_caught);
if (sig_caught == SIGWINCH)
fprintf(stdout, "SIGWINCH\n");
}
return NULL;
}
int main(int argc, char *argv[]) {
pthread_t sig_thr_id;
sigemptyset(&signal_mask);
sigaddset(&signal_mask, SIGWINCH);
sigprocmask(SIG_BLOCK, &signal_mask, NULL);
pthread_create(&sig_thr_id, NULL, signal_thread, NULL);
while(1);
return 0;
}while this works on macOS: #include <stdio.h>
#include <stdlib.h>
#include <pthread.h>
#include <signal.h>
#include <string.h>
#include <errno.h>
static sigset_t signal_mask;
void *signal_thread(void *arg) {
int sig_caught;
while(1) {
sigwait(&signal_mask, &sig_caught);
if (sig_caught == SIGWINCH)
fprintf(stdout, "SIGWINCH\n");
}
return NULL;
}
static void sigHandler(int signo) { }
int main(int argc, char *argv[]) {
pthread_t sig_thr_id;
struct sigaction sa;
sa.sa_handler = sigHandler;
sigaction(SIGWINCH, &sa, 0);
sigemptyset(&signal_mask);
sigaddset(&signal_mask, SIGWINCH);
sigprocmask(SIG_BLOCK, &signal_mask, NULL);
pthread_create(&sig_thr_id, NULL, signal_thread, NULL);
while(1);
return 0;
} |
This is not needed on linux at all! Tried to explain as much as I understand with the problem.
matthewbauer
force-pushed
the
handle-sigwinch
branch
from
9b78766 to
5011a52
Compare
|
I've put an ifdef to just do it on macOS. it looks like it has nothing to do with pthread. This program also doesn't work: #include <stdio.h>
#include <signal.h>
static sigset_t signal_mask;
int main (int argc, char *argv[]) {
sigemptyset(&signal_mask);
sigaddset(&signal_mask, SIGWINCH);
sigprocmask(SIG_BLOCK, &signal_mask, NULL);
int sig_caught;
while (1) {
sigwait(&signal_mask, &sig_caught);
if (sig_caught == SIGWINCH)
fprintf(stdout, "SIGWINCH\n");
}
return 0;
}While this does: #include <stdio.h>
#include <signal.h>
static sigset_t signal_mask;
static void sigHandler(int signo) { }
int main (int argc, char *argv[]) {
struct sigaction sa;
sa.sa_handler = sigHandler;
sigaction(SIGWINCH, &sa, 0);
sigemptyset(&signal_mask);
sigaddset(&signal_mask, SIGWINCH);
sigprocmask(SIG_BLOCK, &signal_mask, NULL);
int sig_caught;
while (1) {
sigwait(&signal_mask, &sig_caught);
if (sig_caught == SIGWINCH)
fprintf(stdout, "SIGWINCH\n");
}
return 0;
} |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the SIGWINCH signal to be caught, it needs to be set in sigaction
on the main thread. Previously, this was broken, and updateWindowSize
was never being called. Tested on macOS 10.14.