Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk-doc: 1.29 -> 1.30 #62634

Merged
merged 6 commits into from Jun 5, 2019
Merged

gtk-doc: 1.29 -> 1.30 #62634

merged 6 commits into from Jun 5, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Reverted the reverts. From what I could tell there weren't any other things failing where just disabling docs
wasn't reasonable. libical still has problems with building docs upstream on the latest release

I could reproduce similar issues locally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from vcunat June 3, 2019 20:12
@ofborg ofborg bot requested a review from pSub June 3, 2019 20:25
@vcunat vcunat changed the base branch from master to staging June 3, 2019 20:36
@vcunat
Copy link
Member

vcunat commented Jun 3, 2019 •
edited

Hydra link (edited) – comparison to latest staging-next is the best I could think of.

I suppose we'll just ignore this ugly commit list shown by GitHub UI. I was lazy to merge master to staging ATM.

@worldofpeace
Copy link
Contributor Author

Hydra link (edited) – comparison to latest staging-next is the best I could think of.

I suppose we'll just ignore this ugly commit list shown by GitHub UI. I was lazy to merge master to staging ATM.

Sounds good thanks. And yeah we can probably just ignore that for now since it isn't important yet.

@vcunat vcunat changed the base branch from staging to master June 5, 2019 09:12
@vcunat vcunat changed the base branch from master to staging June 5, 2019 09:13
vcunat
vcunat approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

GitHub UI still seems a bit confused about this PR.

@vcunat vcunat merged commit dcd42d3 into NixOS:staging Jun 5, 2019
vcunat added a commit that referenced this pull request Jun 5, 2019
@vcunat
Merge #62634: gtk-doc: 1.29 -> 1.30 (again)
26f728e 
... into staging.  Approximate Hydra comparison looks good to me:
https://hydra.nixos.org/eval/1523212?compare=1523031
@worldofpeace worldofpeace deleted the gtk-doc branch June 5, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: python 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @vcunat