nixos/azure: revamp, make it easy to do ongoing maintenance #62635

colemickens · 2019-06-03T20:27:35Z

Motivation for this change

The Azure images are old and there are issues with them:

Upgrading the latest bootable Azure image to stable requires stepping, results in broken image #62228
azure image needs to configure sudo to be password-less #39523 (this PR does not address, I think that security change should be in a separate PR)
Azure version of NixOS blob #36262

The current scripts require a number of pre-requisite steps and are not easy for non-maintainers to pick up and just start using.

Please see the new nixos/maintainers/scripts/azure/README.md for an explanation of what I've added and how to use it.

These changes:

Make it very obvious where to find images, how they were built, how to reproduce them for ones self.
Make it easy to re-use a single function to build custom Azure images with custom nixpkgs.

Remaining TODOs are listed in the README. I'd also like to figure out the Nix API that would be appropriate for allowing callers of mkAzureImage to be able to pass-in the other stuff make-disk-image takes, or extra nixos modules, etc.

This is a WIP since I have some TODOs I'm finishing, but since I've started bugging people in IRC, I wanted to open this.

Things done

colemickens · 2019-06-03T20:29:40Z

Note for reviews, as of right now, there are a number of in-progress, development-y things in this PR that will certainly be removed before it's ready for a real review or merge consideration.

colemickens · 2019-06-04T07:14:35Z

This is ready for review.

colemickens · 2019-06-04T07:15:48Z

nixos/maintainers/scripts/azure/README.md

+nvim ./../../../modules/virtualisation/azure-images.nix
+export AZURE_SUBSCRIPTION_ID="<production NixOS subscription ID>"
+export AZURE_RESOURCE_GROUP="NIXOS_PRODUCTION"
+export AZURE_STORAGE_ACCOUNT="nixosofficial"


Will need to update these when we get the subscription info.
The official account might be a legacy SA in a non-RG, in which case we can try to move it or maybe just make a new "official" storage account, especially since I didn't pull over the very old images anyway.

rbvermaa · 2019-06-04T17:20:04Z

The structure change of nixos/modules/virtualisation/azure-images.nix might break nixops, assuming nixops isn't already broken.

Wrt storage account, I am sure it is still a legacy storage account, since it was created a zillion years ago :-)

colemickens · 2019-06-04T17:25:09Z

Looks like you're right. I'll do something to prevent breaking nixops (further) at least: https://github.com/NixOS/nixops/blob/5cd194e3e91c6af789b449eb719191fe1310772b/nix/eval-machine-info.nix#L240

colemickens · 2019-06-06T04:19:08Z

I patched this up to not touch ./azure-images.nix.

I haven't tested any upgrade scenarios (though I don't think I really change anything substantive). Or NixOps.

ghuntley · 2019-06-09T01:01:45Z

Dropping on by to say thank-you for doing this <3

ghuntley · 2019-06-09T03:06:54Z

Raised NixOS/nixos-homepage#282 which updates instructions on the homepage.

ghuntley · 2019-06-09T03:09:01Z

re: The Azure images are old and there are issues with them:

I can confirm this.

Deployment failed. Correlation ID: 7216c8b3-d58e-46cf-9912-518a3dc54308. {
  "status": "Failed",
  "error": {
    "code": "ResourceDeploymentFailure",
    "message": "The resource operation completed with terminal provisioning state 'Failed'.",
    "details": [
      {
        "code": "InvalidVhd",
        "message": "The VHD for disk 'osdisk_d9edd9a8ee' with blob https://mycoolmachine.blob.core.windows.net/virtual-machines/osdisk_d9edd9a8ee.vhd has an unsupported virtual size of 30719.390625 MB. The size must be a whole number in (MBs)."
      }
    ]
  }
}

colemickens · 2019-06-26T21:53:30Z

Note, if Azure uses grow partition, and if I recall my own work from 2 weeks ago, it does... then we should also push for this to be merged: #58471

BTW: This branch isn't in a good state to be merged. I think I did a bunch of fixes on a VM and then blew away the machine without pushing the changes up. I'll have to to do it again and there are a few other things on the list first.

colemickens · 2019-07-25T20:22:26Z

I've refactored this again locally. I've got it to where it can replicate images across all regions, etc, but I'm frankly losing any interest in supporting anything related to Azure. See this issue for an example of one of the many reasons: Azure/azure-cli#10041 (comment)

ghuntley · 2019-07-26T01:09:13Z

Push your bits please :-)

baracoder · 2019-08-05T13:11:37Z

Even if there won't be an official NixOS image, we could maybe still profit from the improvements when creating our custom images. Please push your changes @colemickens

idontgetoutmuch · 2019-09-10T09:09:48Z

Are there any images I can try? I wasn't able to follow what was going on from the above conversation.

idontgetoutmuch · 2019-09-10T09:11:03Z

re: The Azure images are old and there are issues with them:

I can confirm this.

Deployment failed. Correlation ID: 7216c8b3-d58e-46cf-9912-518a3dc54308. {
  "status": "Failed",
  "error": {
    "code": "ResourceDeploymentFailure",
    "message": "The resource operation completed with terminal provisioning state 'Failed'.",
    "details": [
      {
        "code": "InvalidVhd",
        "message": "The VHD for disk 'osdisk_d9edd9a8ee' with blob https://mycoolmachine.blob.core.windows.net/virtual-machines/osdisk_d9edd9a8ee.vhd has an unsupported virtual size of 30719.390625 MB. The size must be a whole number in (MBs)."
      }
    ]
  }
}

I get the same error with the current instructions.

idontgetoutmuch · 2019-09-11T11:02:38Z

bash-3.2$ ./images-ensure.sh
./images-ensure.sh: line 13: syntax error near unexpected token `&'

It turns out the shell on macOS is really old but I now get

sh-3.2$ ./images-ensure.sh
unpacking 'https://github.com/nixos/nixpkgs/archive/606306e0eaacdaba1d3ada33485ae4cb413faeb5.tar.gz'...
error: cannot coerce a list to a string, at /nix/store/fn7rjrsjb8xbllfdvpbfz0riir2xcqn5-source/lib/modules.nix:109:60

colemickens · 2019-09-11T11:23:49Z

@idontgetoutmuch My azure branch currently has instructions that will let you build and boot a custom image, along with a script to build a "SIG Image" which can then be automatically replicated to new regions, etc. When I finish testing and writing the docs for the "release" process, I will clean up this PR and we can get a new proper image released. I just pushed a new commit that is mostly-ish tested.

Hopefully as a follow up, we can remove all of the old images. I really don't think there's any point in keeping them around.

idontgetoutmuch · 2019-09-11T13:12:26Z

@colemickens great :) - at the moment I am just trying to build an image. I am logging what happens as I go in #62635 (comment).

idontgetoutmuch · 2019-09-11T14:56:11Z

sh-3.2$ group="nixosvhds"     # target resource group
sh-3.2$ diskname="nixosDisk1" # disk name
sh-3.2$ size="50"             # disk size in GB
sh-3.2$ location="uksouth"    # (mostly unimportant due to SIG replication)
sh-3.2$ ./az.sh login
Password:
Unable to find image 'microsoft/azure-cli:latest' locally
latest: Pulling from microsoft/azure-cli











Digest: sha256:1b54c06ce907f2332d201108be5963f5e8085122502805dba9b11b0cad1d99ad
Status: Downloaded newer image for microsoft/azure-cli:latest
docker: Error response from daemon: Mounts denied: 
The path /nix
is not shared from OS X and is not known to Docker.
You can configure shared paths from Docker -> Preferences... -> File Sharing.
See https://docs.docker.com/docker-for-mac/osxfs/#namespaces for more info.
.

idontgetoutmuch · 2019-09-13T09:21:15Z

I replace ./az.sh by az and azcopy by azure-storage-azcopy. I am not sure what to do about the unrecognised flag.

sundials@sundials:~/nixpkgs/nixos/maintainers/scripts/azure$ azimage="$(group=nixos-user-vhds ./create-image.sh "${imagename}" "${source}")"
+ set -euo pipefail
+ group=nixos-user-vhds
+ size=50
+ location=westus2
+ diskname=nixos_1903_20190911_103149
+ shift
+ source='https://md-mr3x0kwh0vs4.blob.core.windows.net/cl4lqwtjlfjz/abcd?sv=2017-04-17&sr=b&si=f23dad83-cb40-4e7d-8f58-2be43113a97a&sig=SWdIsY7GJTT08LFCqpOKMxLWRAHx6PBJDk1ibdI5Wkw%3D'
+ shift
+ az group create --name nixos-user-vhds --location westus2
+ az disk create --resource-group nixos-user-vhds --name nixos_1903_20190911_103149 --size-gb 50 --for-upload true
+ timeout=3600
++ az disk grant-access --access-level Write --resource-group nixos-user-vhds --name nixos_1903_20190911_103149 --duration-in-seconds 3600
++ jq -r .accessSas
+ sasurl='https://md-impexp-lkfdfxjnc3dt.blob.core.windows.net/l2jtddx22vgj/abcd?sv=2017-04-17&sr=b&si=00dbabd0-4c83-459b-9ff7-d172a5a4cfe3&sig=tb42ljW6lVAzXWVcLsNM%2FYKXyFTFbzzhu6jB6FLELsc%3D'
+ azure-storage-azcopy copy 'https://md-mr3x0kwh0vs4.blob.core.windows.net/cl4lqwtjlfjz/abcd?sv=2017-04-17&sr=b&si=f23dad83-cb40-4e7d-8f58-2be43113a97a&sig=SWdIsY7GJTT08LFCqpOKMxLWRAHx6PBJDk1ibdI5Wkw%3D' 'https://md-impexp-lkfdfxjnc3dt.blob.core.windows.net/l2jtddx22vgj/abcd?sv=2017-04-17&sr=b&si=00dbabd0-4c83-459b-9ff7-d172a5a4cfe3&sig=tb42ljW6lVAzXWVcLsNM%2FYKXyFTFbzzhu6jB6FLELsc%3D' --blob-type PageBlob
Error: unknown flag: --blob-type
Usage:
  azcopy copy [source] [destination] [flags]

Aliases:
  copy, cp, c

Examples:
Upload a single file:
  - azcopy cp "/path/to/file.txt" "https://[account].blob.core.windows.net/[container]/[path/to/blob]?[SAS]"

Upload a single file through piping(block blob only):
  - cat "/path/to/file.txt" | azcopy cp "https://[account].blob.core.windows.net/[container]/[path/to/blob]?[SAS]"

Upload an entire directory:
  - azcopy cp "/path/to/dir" "https://[account].blob.core.windows.net/[container]/[path/to/directory]?[SAS]" --recursive=true

Upload only files using wildcards:
  - azcopy cp "/path/*foo/*bar/*.pdf" "https://[account].blob.core.windows.net/[container]/[path/to/directory]?[SAS]"

Upload files and directories using wildcards:
  - azcopy cp "/path/*foo/*bar*" "https://[account].blob.core.windows.net/[container]/[path/to/directory]?[SAS]" --recursive=true

Download a single file:
  - azcopy cp "https://[account].blob.core.windows.net/[container]/[path/to/blob]?[SAS]" "/path/to/file.txt"

Download a single file through piping(blobs only):
  - azcopy cp "https://[account].blob.core.windows.net/[container]/[path/to/blob]?[SAS]" > "/path/to/file.txt"

Download an entire directory:
  - azcopy cp "https://[account].blob.core.windows.net/[container]/[path/to/directory]?[SAS]" "/path/to/dir" --recursive=true

Download files using wildcards:
  - azcopy cp "https://[account].blob.core.windows.net/[container]/foo*?[SAS]" "/path/to/dir"

Download files and directories using wildcards:
  - azcopy cp "https://[account].blob.core.windows.net/[container]/foo*?[SAS]" "/path/to/dir" --recursive=true


Flags:
      --block-blob-tier string        upload block blob to Azure Storage using this blob tier. (default "None")
      --block-size uint32             use this block(chunk) size when uploading/downloading to/from Azure Storage.
      --content-encoding string       upload to Azure Storage using this content encoding.
      --content-type string           specifies content type of the file. Implies no-guess-mime-type.
      --exclude string                exclude these files when copying. Support use of *.
      --follow-symlinks               follow symbolic links when uploading from local file system.
      --fromTo string                 optionally specifies the source destination combination. For Example: LocalBlob, BlobLocal, LocalBlobFS.
  -h, --help                          help for copy
      --log-level string              define the log verbosity for the log file, available levels: DEBUG, INFO, WARNING, ERROR, PANIC, and FATAL. (default "INFO")
      --metadata string               upload to Azure Storage with these key-value pairs as metadata.
      --no-guess-mime-type            this sets the content-type based on the extension of the file.
      --overwrite                     overwrite the conflicting files/blobs at the destination if this flag is set to true. (default true)
      --page-blob-tier string         upload page blob to Azure Storage using this blob tier. (default "None")
      --preserve-last-modified-time   only available when destination is file system.
      --recursive                     look into sub-directories recursively when uploading from local file system.
      --with-snapshots                include the snapshots. Only valid when the source is blobs.

idontgetoutmuch · 2019-09-13T13:46:20Z

sundials@sundials:~/nixpkgs/nixos/maintainers/scripts/azure$ azsigimage="$(group=nixos-user-vhds ./create-sig-image-version.sh "1.0.0" "${azimage}")"
+ set -euo pipefail
+ group=nixos-user-vhds
+ sig_imageversion=1.0.0
+ shift
+ imageid='{
  "id": "/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds",
  "location": "westus2",
  "managedBy": null,
  "name": "nixos-user-vhds",
  "properties": {
    "provisioningState": "Succeeded"
  },
  "tags": null,
  "type": "Microsoft.Resources/resourceGroups"
}
{
  "creationData": {
    "createOption": "Upload",
    "imageReference": null,
    "sourceResourceId": null,
    "sourceUri": null,
    "storageAccountId": null
  },
  "diskIopsReadWrite": 240,
  "diskMbpsReadWrite": 50,
  "diskSizeGb": 50,
  "diskState": "ActiveUpload",
  "encryptionSettingsCollection": null,
  "hyperVgeneration": "V1",
  "id": "/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds/providers/Microsoft.Compute/disks/nixos_1903_20190911_103149",
  "location": "westus2",
  "managedBy": null,
  "name": "nixos_1903_20190911_103149",
  "osType": null,
  "provisioningState": "Succeeded",
  "resourceGroup": "nixos-user-vhds",
  "sku": {
    "name": "Premium_LRS",
    "tier": "Premium"
  },
  "tags": {},
  "timeCreated": "2019-09-13T08:41:56.078229+00:00",
  "type": "Microsoft.Compute/disks",
  "zones": null
}
INFO: Scanning...

Job 37bf3682-4d04-5449-4917-2d9c4bda9de7 has started
Log file is located at: /home/sundials/.azcopy/37bf3682-4d04-5449-4917-2d9c4bda9de7.log

0 Done, 0 Failed, 1 Pending, 0 Skipped, 1 Total, 2-sec Throughput (Mb/s): 335.4941                                


Job 37bf3682-4d04-5449-4917-2d9c4bda9de7 summary
Elapsed Time (Minutes): 18.7028
Total Number Of Transfers: 1
Number of Transfers Completed: 1
Number of Transfers Failed: 0
Number of Transfers Skipped: 0
TotalBytesTransferred: 53687091712
Final Job Status: Completed

/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds/providers/Microsoft.Compute/images/nixos_1903_20190911_103149'
+ shift
+ gallery=nixosvhds
+ publisher=nixos
+ offer=nixos
+ sku=nixos
+ sig_imagename=nixos
+ az group create -n nixos-user-vhds -l westus2
+ az sig create --resource-group nixos-user-vhds --gallery-name nixosvhds
+ az sig image-definition create --resource-group nixos-user-vhds --gallery-name nixosvhds --gallery-image nixos --publisher nixos --offer nixos --sku nixos --os-type linux
+ az sig image-version create --resource-group nixos-user-vhds --gallery-name nixosvhds --gallery-image-definition nixos --gallery-image-version 1.0.0 --target-regions WestCentralUS WestUS2 WestUS --replica-count 2 --managed-image '{
  "id": "/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds",
  "location": "westus2",
  "managedBy": null,
  "name": "nixos-user-vhds",
  "properties": {
    "provisioningState": "Succeeded"
  },
  "tags": null,
  "type": "Microsoft.Resources/resourceGroups"
}
{
  "creationData": {
    "createOption": "Upload",
    "imageReference": null,
    "sourceResourceId": null,
    "sourceUri": null,
    "storageAccountId": null
  },
  "diskIopsReadWrite": 240,
  "diskMbpsReadWrite": 50,
  "diskSizeGb": 50,
  "diskState": "ActiveUpload",
  "encryptionSettingsCollection": null,
  "hyperVgeneration": "V1",
  "id": "/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds/providers/Microsoft.Compute/disks/nixos_1903_20190911_103149",
  "location": "westus2",
  "managedBy": null,
  "name": "nixos_1903_20190911_103149",
  "osType": null,
  "provisioningState": "Succeeded",
  "resourceGroup": "nixos-user-vhds",
  "sku": {
    "name": "Premium_LRS",
    "tier": "Premium"
  },
  "tags": {},
  "timeCreated": "2019-09-13T08:41:56.078229+00:00",
  "type": "Microsoft.Compute/disks",
  "zones": null
}
INFO: Scanning...

Job 37bf3682-4d04-5449-4917-2d9c4bda9de7 has started
Log file is located at: /home/sundials/.azcopy/37bf3682-4d04-5449-4917-2d9c4bda9de7.log

0 Done, 0 Failed, 1 Pending, 0 Skipped, 1 Total, 2-sec Throughput (Mb/s): 335.4941                                


Job 37bf3682-4d04-5449-4917-2d9c4bda9de7 summary
Elapsed Time (Minutes): 18.7028
Total Number Of Transfers: 1
Number of Transfers Completed: 1
Number of Transfers Failed: 0
Number of Transfers Skipped: 0
TotalBytesTransferred: 53687091712
Final Job Status: Completed

/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds/providers/Microsoft.Compute/images/nixos_1903_20190911_103149'
Id /subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds/providers/Microsoft.Compute/images/{
  "id": "/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds",
  "location": "westus2",
  "managedBy": null,
  "name": "nixos-user-vhds",
  "properties": {
    "provisioningState": "Succeeded"
  },
  "tags": null,
  "type": "Microsoft.Resources/resourceGroups"
}
{
  "creationData": {
    "createOption": "Upload",
    "imageReference": null,
    "sourceResourceId": null,
    "sourceUri": null,
    "storageAccountId": null
  },
  "diskIopsReadWrite": 240,
  "diskMbpsReadWrite": 50,
  "diskSizeGb": 50,
  "diskState": "ActiveUpload",
  "encryptionSettingsCollection": null,
  "hyperVgeneration": "V1",
  "id": "/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds/providers/Microsoft.Compute/disks/nixos_1903_20190911_103149",
  "location": "westus2",
  "managedBy": null,
  "name": "nixos_1903_20190911_103149",
  "osType": null,
  "provisioningState": "Succeeded",
  "resourceGroup": "nixos-user-vhds",
  "sku": {
    "name": "Premium_LRS",
    "tier": "Premium"
  },
  "tags": {},
  "timeCreated": "2019-09-13T08:41:56.078229+00:00",
  "type": "Microsoft.Compute/disks",
  "zones": null
}
INFO: Scanning...

Job 37bf3682-4d04-5449-4917-2d9c4bda9de7 has started
Log file is located at: /home/sundials/.azcopy/37bf3682-4d04-5449-4917-2d9c4bda9de7.log

0 Done, 0 Failed, 1 Pending, 0 Skipped, 1 Total, 2-sec Throughput (Mb/s): 335.4941                                


Job 37bf3682-4d04-5449-4917-2d9c4bda9de7 summary
Elapsed Time (Minutes): 18.7028
Total Number Of Transfers: 1
Number of Transfers Completed: 1
Number of Transfers Failed: 0
Number of Transfers Skipped: 0
TotalBytesTransferred: 53687091712
Final Job Status: Completed

/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds/providers/Microsoft.Compute/images/nixos_1903_20190911_103149 is not a valid resource reference.
sundials@sundials:~/nixpkgs/nixos/maintainers/scripts/azure$

idontgetoutmuch · 2019-09-13T14:35:04Z

sundials@sundials:~/nixpkgs/nixos/maintainers/scripts/azure$ az vm create   --name "testVM"   --resource-group "${group}"   --os-disk-size-gb "100"   --image "${azsigimage}"   --admin-username "${USER}"   --location "WestCentralUS"   --ssh-key-values "$(ssh-add -L)"
Querying the image of '{
  "id": "/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds",
  "location": "westus2",
  "managedBy": null,
  "name": "nixos-user-vhds",
  "properties": {
    "provisioningState": "Succeeded"
  },
  "tags": null,
  "type": "Microsoft.Resources/resourceGroups"
}
{
  "description": null,
  "id": "/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds/providers/Microsoft.Compute/galleries/nixosvhds",
  "identifier": {
    "uniqueName": "9ea70aed-5274-4570-acd6-7066d8382e36-NIXOSVHDS"
  },
  "location": "westus2",
  "name": "nixosvhds",
  "provisioningState": "Succeeded",
  "resourceGroup": "nixos-user-vhds",
  "tags": {},
  "type": "Microsoft.Compute/galleries"
}
{
  "description": null,
  "disallowed": null,
  "endOfLifeDate": null,
  "eula": null,
  "id": "/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/resourceGroups/nixos-user-vhds/providers/Microsoft.Compute/galleries/nixosvhds/images/nixos",
  "identifier": {
    "offer": "nixos",
    "publisher": "nixos",
    "sku": "nixos"
  },
  "location": "westus2",
  "name": "nixos",
  "osState": "Generalized",
  "osType": "Linux",
  "privacyStatementUri": null,
  "provisioningState": "Succeeded",
  "purchasePlan": null,
  "recommended": null,
  "releaseNoteUri": null,
  "resourceGroup": "nixos-user-vhds",
  "tags": {},
  "type": "Microsoft.Compute/galleries/images"
}' failed for an error 'Operation failed with status: 'Bad Request'. Details: 400 Client Error: Bad Request for url: https://management.azure.com/subscriptions/9ea70aed-5274-4570-acd6-7066d8382e36/providers/Microsoft.Compute/locations/WestCentralUS/publishers/%7B%0A%20%20%22id%22/artifacttypes/vmimage/offers/%20%22%2Fsubscriptions%2F9ea70aed-5274-4570-acd6-7066d8382e36%2FresourceGroups%2Fnixos-user-vhds%22%2C%0A%20%20%22location%22/skus/%20%22westus2%22%2C%0A%20%20%22managedBy%22/versions/%20null%2C%0A%20%20%22name%22?api-version=2019-03-01'. Configuring plan settings will be skipped
Deployment failed. Correlation ID: d74f3f7e-9a74-4388-a347-5e8a8b1d9f25. {
  "error": {
    "code": "InvalidParameter",
    "message": "The value of parameter imageReference.publisher is invalid.",
    "target": "imageReference.publisher"
  }
}

colemickens · 2020-03-28T02:00:42Z

This is basically superseded by : #78827

ofborg bot added 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jun 3, 2019

colemickens force-pushed the azure-pr branch 2 times, most recently from e5c95e0 to 34f29b0 Compare June 4, 2019 07:13

azure revamp

d089806

colemickens force-pushed the azure-pr branch from 34f29b0 to d089806 Compare June 4, 2019 07:14

colemickens changed the title ~~WIP: nixos/azure: revamp, make it easy to do ongoing maintenance~~ nixos/azure: revamp, make it easy to do ongoing maintenance Jun 4, 2019

colemickens commented Jun 4, 2019

View reviewed changes

lheckemann added this to the 20.03 milestone Sep 10, 2019

disassembler modified the milestones: 20.03, 20.09 Feb 5, 2020

colemickens closed this Mar 28, 2020

colemickens deleted the azure-pr branch April 20, 2020 06:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nixos/azure: revamp, make it easy to do ongoing maintenance #62635

nixos/azure: revamp, make it easy to do ongoing maintenance #62635

colemickens commented Jun 3, 2019

colemickens commented Jun 3, 2019

colemickens commented Jun 4, 2019

colemickens Jun 4, 2019

rbvermaa commented Jun 4, 2019

colemickens commented Jun 4, 2019 •

edited

colemickens commented Jun 6, 2019

ghuntley commented Jun 9, 2019

ghuntley commented Jun 9, 2019 •

edited

ghuntley commented Jun 9, 2019

colemickens commented Jun 26, 2019

colemickens commented Jul 25, 2019

ghuntley commented Jul 26, 2019

baracoder commented Aug 5, 2019

idontgetoutmuch commented Sep 10, 2019

idontgetoutmuch commented Sep 10, 2019

idontgetoutmuch commented Sep 11, 2019 •

edited

colemickens commented Sep 11, 2019

idontgetoutmuch commented Sep 11, 2019

idontgetoutmuch commented Sep 11, 2019

idontgetoutmuch commented Sep 13, 2019 •

edited

idontgetoutmuch commented Sep 13, 2019 •

edited

idontgetoutmuch commented Sep 13, 2019

colemickens commented Mar 28, 2020

nixos/azure: revamp, make it easy to do ongoing maintenance #62635

nixos/azure: revamp, make it easy to do ongoing maintenance #62635

Conversation

colemickens commented Jun 3, 2019

Motivation for this change

Things done

colemickens commented Jun 3, 2019

colemickens commented Jun 4, 2019

colemickens Jun 4, 2019

Choose a reason for hiding this comment

rbvermaa commented Jun 4, 2019

colemickens commented Jun 4, 2019 • edited

colemickens commented Jun 6, 2019

ghuntley commented Jun 9, 2019

ghuntley commented Jun 9, 2019 • edited

ghuntley commented Jun 9, 2019

colemickens commented Jun 26, 2019

colemickens commented Jul 25, 2019

ghuntley commented Jul 26, 2019

baracoder commented Aug 5, 2019

idontgetoutmuch commented Sep 10, 2019

idontgetoutmuch commented Sep 10, 2019

idontgetoutmuch commented Sep 11, 2019 • edited

colemickens commented Sep 11, 2019

idontgetoutmuch commented Sep 11, 2019

idontgetoutmuch commented Sep 11, 2019

idontgetoutmuch commented Sep 13, 2019 • edited

idontgetoutmuch commented Sep 13, 2019 • edited

idontgetoutmuch commented Sep 13, 2019

colemickens commented Mar 28, 2020

colemickens commented Jun 4, 2019 •

edited

ghuntley commented Jun 9, 2019 •

edited

idontgetoutmuch commented Sep 11, 2019 •

edited

idontgetoutmuch commented Sep 13, 2019 •

edited

idontgetoutmuch commented Sep 13, 2019 •

edited