Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thin-provisioning-tools: 0.7.6 -> 0.8.5 #62700

Closed
wants to merge 2 commits into from
Closed

thin-provisioning-tools: 0.7.6 -> 0.8.5 #62700

wants to merge 2 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from globin June 4, 2019 23:50
@dtzWill dtzWill changed the title thin-provisioning-tools: 0.7.6 -> 0.8.2 thin-provisioning-tools: 0.7.6 -> 0.8.5 Jun 5, 2019
@rixed
Copy link
Contributor

rixed commented Nov 17, 2019

sha256 seems to be 01wl8c0cjbx1smbhj8dx6av5bnw5775m58gasc3vqwvsj0s9hq19 ATM.
The repo must have been push -fed.

@drewrisinger
Copy link
Contributor

This PR has conflicts. Can you please rebase to resolve those?

Also, could you add yourself as maintainer & squash upgrade commits?

Currently not able to run nixpkgs-review on this due to out-of-date branch, I think.

@SuperSandro2000
Copy link
Member

Version in master is newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @rixed @drewrisinger @SuperSandro2000 @ryantm