Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wlroots: 0.5.0 -> 0.6.0 #60894

Closed
wants to merge 1 commit into from
Closed

wlroots: 0.5.0 -> 0.6.0 #60894

wants to merge 1 commit into from

Conversation

primeos
Copy link
Member

@primeos primeos commented May 3, 2019

Motivation for this change

This actually needs to wait for a bit since neither Sway nor Waybar are compatible with 0.6.0 (backwards incompatible changes). Since those are the only packages that depend on wlroots atm, it doesn't really make sense to merge this update yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos primeos self-assigned this May 3, 2019
@colemickens
Copy link
Member

Is Waybar still actually broken with 0.6.0? Is it time to merge this, especially since Sway 1.1 is out?

@primeos
Copy link
Member Author

primeos commented Jun 4, 2019 •
edited

Is Waybar still actually broken with 0.6.0?

Oh, I forgot to remove that note. I later realized that I didn't pay enough attention to the log and I didn't know that Waybar depends on Sway, so I was actually still seeing the build failure for Sway and not Waybar :o

Is it time to merge this, especially since Sway 1.1 is out?

Yeah, but @Synthetica9 already opened an additional PR (#62608) which also contains the Sway update so I should probably close this PR now...

@primeos primeos closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @colemickens