compat.fhdl.specials: fix TSTriple conversion. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, this is completely wrong. What are you doing exactly that you need this? |
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
- Coverage 80.75% 80.72% -0.04%
==========================================
Files 32 32
Lines 4910 4912 +2
Branches 1060 1060
==========================================
Hits 3965 3965
- Misses 818 820 +2
Partials 127 127
Continue to review full report at Codecov.
|
|
My old migen code uses the automatic SB_IO generation for tristates. This seemed to be what ice40_platform.py wanted for this to work, but indeed it doesn't. |
|
Should be fixed in 79a3710. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is correct but it does get me farther.