Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luaPackages.lpeg: 1.0.1 -> 1.0.2 #62716

Merged
merged 1 commit into from Jun 7, 2019
Merged

luaPackages.lpeg: 1.0.1 -> 1.0.2 #62716

merged 1 commit into from Jun 7, 2019

Conversation

teto
Copy link
Member

@teto teto commented Jun 5, 2019 •
edited

and move to generated.

Tested with nix-review.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: lua label Jun 5, 2019
@ofborg ofborg bot requested a review from vcunat June 5, 2019 06:53
@teto
Copy link
Member Author

teto commented Jun 5, 2019

CC @vyp this effectively removes you from the maintainer's list.
As the generated package is straightforward I think it should be ok in general but I will add the possibility to add maintainers in the generated packages.

OPNA2608
OPNA2608 reviewed Jun 5, 2019
View reviewed changes
pkgs/development/lua-modules/generated-packages.nix
propagatedBuildInputs = [ lua ];

meta = {
homepage = "http://www.inf.puc-rio.br/~roberto/lpeg.html";
Copy link
Contributor

@OPNA2608 OPNA2608 Jun 5, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct homepage is our previous one without .html, this one redirects to a 404 page. A minor annoyance that we're inheriting this wrong homepage link from the luarocks package now, if you ask me.

Dunno where you'd have to report that to get it fixed, I don't see anything helpful on the webpage.
https://luarocks.org/modules/gvvaughan/lpeg

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. I sent him a mail. let's see. Hopefully the correct url can be picked up in the next update.

@vcunat
Copy link
Member

vcunat commented Jun 5, 2019 •
edited

I've been adding myself to meta.maintainers of other such packages via the override mechanism. Example: 6108e63a0#diff-331536475bf2bc6334d8bbc670b8216bR81

@teto
Copy link
Member Author

teto commented Jun 5, 2019

yep that's possible but not as readable. I will implement a better solution.

@teto
luaPackages.lpeg: 1.0.1 -> 1.0.2
cbce301 
and move to generated
@teto
Copy link
Member Author

teto commented Jun 7, 2019

Merging because I don't want to rebase as I upload/convert more lua packages. I notified the author about the url problem, hopefully it gets solved in the next update.

@teto teto merged commit 128ca15 into NixOS:master Jun 7, 2019
@teto teto deleted the lua_lpeg branch June 7, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 OPNA2608 left review comments

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @vcunat @OPNA2608