Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icr: do not wrap crystal so we can use one from the environment #62759

Merged
merged 1 commit into from Jun 6, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Further to #61156, do not wrap crystal so icr will work with whatever crystal is currently available in the environment.

This means that installing icr on its own isn't enough to make it work - you need to have crystal available, either in the global environment, the user environment or using something like direnv (recommended).

Cc: @c0bw3b

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b merged commit 3d83ab0 into NixOS:master Jun 6, 2019
@peterhoeg peterhoeg deleted the f/icr branch June 6, 2019 13:49
@peterhoeg peterhoeg restored the f/icr branch June 7, 2019 01:45
@peterhoeg peterhoeg deleted the f/icr branch June 14, 2019 01:52
@peterhoeg peterhoeg restored the f/icr branch June 14, 2019 12:27
@peterhoeg peterhoeg deleted the f/icr branch June 20, 2019 09:29
@peterhoeg peterhoeg restored the f/icr branch June 20, 2019 12:04
@peterhoeg peterhoeg deleted the f/icr branch June 26, 2019 02:51
@peterhoeg peterhoeg restored the f/icr branch June 27, 2019 05:20
@peterhoeg peterhoeg deleted the f/icr branch July 3, 2019 10:29
@peterhoeg peterhoeg restored the f/icr branch July 4, 2019 01:22
@peterhoeg peterhoeg deleted the f/icr branch July 16, 2019 23:43
@peterhoeg peterhoeg restored the f/icr branch July 18, 2019 01:27
@peterhoeg peterhoeg deleted the f/icr branch July 24, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants