Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luazip update #62717

Merged
merged 2 commits into from Jun 6, 2019
Merged

Luazip update #62717

merged 2 commits into from Jun 6, 2019

Conversation

teto
Copy link
Member

@teto teto commented Jun 5, 2019 •
edited

Motivation for this change

More automation \o/

Things done

tested with nix-review

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

teto added 2 commits June 5, 2019 16:20
@teto
luaPackages.luazip: 2007-10-30 -> 1.2.7
704358d
@teto
lua: removed zip.nix orphan file
f67d859 
I couldn't find any reference to it and luazip was already packaged in
lua-packages.nix (now generated).
@teto
Copy link
Member Author

teto commented Jun 5, 2019

cc @7c6f434c

@7c6f434c
Copy link
Member

7c6f434c commented Jun 5, 2019

Well, I don't actually have any opinion on specific Lua packages… abstractly looks good

@teto
Copy link
Member Author

teto commented Jun 6, 2019

haha I just didn't want to push and merge my own commits without external review but I guess this is not critical enough that I can do it :)

@teto teto merged commit 7a35dce into NixOS:master Jun 6, 2019
@teto teto deleted the luazip branch June 6, 2019 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: lua 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @7c6f434c