Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: 0.7.13 -> 0.8.0 #62763

Merged
merged 1 commit into from Jun 7, 2019
Merged

zfs: 0.7.13 -> 0.8.0 #62763

merged 1 commit into from Jun 7, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 6, 2019 •
edited

Same as zfsUnstable for the moment.
We still keep the zfsUnstable expression as we likely
need it in the near future again.
Also remove spl since it is no longer needed.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jun 6, 2019

As promised in #61969 (comment)

cc @fpletz @grahamc @sjau

@Mic92
zfs: 0.7.13 -> 0.8.0
11b8a5f 
Same as zfsUnstable for the moment.
We still keep the zfsUnstable expression as we likely
need it in the near future again.
Also remove spl since it is no longer needed.
markuskowa
markuskowa approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ZFS test runs.

@Mic92 Mic92 merged commit 48bb168 into NixOS:master Jun 7, 2019
@Mic92 Mic92 deleted the zfs branch June 7, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @fpletz @markuskowa