Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.ImageExifTool: 11.30 -> 11.48 #62633

Merged
merged 1 commit into from Jun 6, 2019
Merged

perlPackages.ImageExifTool: 11.30 -> 11.48 #62633

merged 1 commit into from Jun 6, 2019

Conversation

bdesham
Copy link
Contributor

@bdesham bdesham commented Jun 3, 2019

Motivation for this change

ExifTool 11.45 fixed an issue that could cause data corruption when a file was edited in turn by ExifTool and by Canon Digital Photo Professional. This PR upgrades the package to 11.48, which is currently the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu 16.04.6)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 62633 1

10 package were build:
  • digikam (digikam5)
  • exiftool (digikam5)
  • fgallery (digikam5)
  • hugin (digikam5)
  • pdf-redact-tools (digikam5)
  • python27Packages.thumbor (digikam5)
  • rapid-photo-downloader (digikam5)
  • shutter (digikam5)
  • styx (digikam5)
  • timelapse-deflicker (digikam5)

@c0bw3b c0bw3b merged commit d4a6e8b into NixOS:master Jun 6, 2019
@bdesham bdesham deleted the exiftool-11.48 branch June 6, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdesham @c0bw3b