haskellPackages: Don't ignore old overrides #62742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
reviewed
Jun 5, 2019
pkgs/top-level/all-packages.nix
Outdated
| overrides = haskell.packageOverrides; | ||
| }); | ||
| haskellPackages = dontRecurseIntoAttrs (haskell.packages.ghc865.override (old: { | ||
| overrides = lib.composeExtensions (old.overrides or (self: super: {})) haskell.packageOverrides; |
There was a problem hiding this comment.
Is haskell.packageOverrides even necessary here? ghc865 should pick it up from:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/haskell-packages.nix#L24
There was a problem hiding this comment.
Not really sure, there might be some .extend/.override/packageOverrides whatever magic we're not seeing here, or maybe not. Unless somebody has a reason to keep this, I'll just remove this.
There was a problem hiding this comment.
Yeah actually you're right, this is handled already, I'll remove the ugliness here
This prevented haskell.packages.${compiler} overlays from propagating
to haskellPackages.
infinisil
force-pushed
the
haskellPackages-overrides
branch
from
e68162d
to
8ac6e24
Compare
|
I verified with this that (import ./. {
overlays = [(self: super: {
haskell = super.haskell // {
packageOverrides = hself: hsuper: {
flobberglab = "Hello";
};
};
})];
}).haskellPackages.flobberglabI'll go ahead and merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevented
pkgs.haskell.packages.${compiler}overlays from propagatingto
pkgs.haskellPackagesE.g. if you use this overlay:
You now have access to
foobarbazthroughpkgs.haskellPackages.foobarbazin addition topkgs.haskell.packages.ghc865.foobarbaz.Pinging @peti @r-ryantm @basvandijk @domenkozar