Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.spglib: add patch fixing darwin/py27 build #62740

Merged
merged 1 commit into from Jun 9, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 5, 2019

Motivation for this change

In trying to fix the darwin py27 build for this package, realized it was an upstream problem. Opened upstream issue https://github.com/atztogo/spglib/issues/78, turns out the problem was an incorrect assertion and darwin/py27 was the only combination where its assert() wasn't acting as a no-op, so tripping up on this problem.

pythonPackages.seekpath reverse-dependency seems broken, so nox-review doesn't quite build fully, but this doesn't break anything new. Tested on non-nixos linux x86_64 and macos 10.13.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner June 5, 2019 21:25
@matthewbauer matthewbauer merged commit 8ca59e0 into NixOS:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants