Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luaPackages.luadbi: 0.7.1 -> 0.7.2 #62663

Closed
wants to merge 1 commit into from
Closed

luaPackages.luadbi: 0.7.1 -> 0.7.2 #62663

wants to merge 1 commit into from

Conversation

teto
Copy link
Member

@teto teto commented Jun 4, 2019

move to generated.
I ran a nix-review on it with success (built prosody fine) and tried to start prosody but it does nothing, not sure how to properly test it.

/cc @sshisk

related PR #62298

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member Author

teto commented Jun 11, 2019

this looks best done manually (or we should split into one module per db as in https://luarocks.org/search?q=luadbi).

Makefile https://github.com/mwild1/luadbi/blob/master/Makefile

@teto teto closed this Jun 11, 2019
@teto teto deleted the luadbi branch September 5, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant