Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua updater update :) #62654

Merged
merged 7 commits into from Jun 4, 2019
Merged

Lua updater update :) #62654

merged 7 commits into from Jun 4, 2019

Conversation

teto
Copy link
Member

@teto teto commented Jun 4, 2019 •
edited

Motivated by @dtzWill work on improving luarocks-nix and because I wanted to move some packages to the generated ones, I've done some cleanup first (will convert the packages in a follow up PR).

To sum up:

  • bumps luarocks-nix fixing some indentation issues, stop crashing upon missing package description, also saves test dependencies (new addition in luarocks rockspec format 3). There seems to be a slight indent regression on the fetchFromGit aspect but that part is ugly anyway and I am looking forward to a replacement anyway.
  • allows to specify a target interpreter. For isntance when trying to generate "digestif" (a latex LSP server) that works only for lua5.3, the current script won't work because it is launched with the interpreter 5.2. Luarocks allows to pass --lua-dir to specify an alternate target lua which is what I use.
  • use --server-only instead of --server . I realized luarocks would sometimes fetch an update from a different server than the one that I specified :s this should make the script faster as well as more deterministic
  • Now that luarocks-nix supports rockspec, some server constraints (basically pointing at my own manifest on luarocks.org) become unnecessary and can now point at the official version. I plan to remove some others in a follow up PR.
  • the update script would fail with no argument without displaying the help. Fixed.

I regenerated the generated-packages.csv which bumps the nvim client, luassert and luv. @dtzWill could you check the luv update please ?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

teto added 7 commits June 4, 2019 18:57
@teto
luarocks-nix: update that fixes indentation
441ef28 
Finally fixes indentation.
- removed buildType as it was not used
- doesn't crash on missing description anymore
@teto
update-luarocks: doesn't crash when no arguments
cf45c78 
define print_help function before it gets called.
@teto
update-luarocks: contact only the specified server
e967121 
use --server-only instead of --server, I haven't run any testing but it
should be a bit faster as well as more deterministic.
@teto
update-luarocks: can install for a different lua
6402fbb 
the recent luarocks can install for a different interpreter than the one
running luarocks.
Due to the way the update is done on nix, it seems more practical to use
this feature than running the script with different luarocks-nix ?
@teto
luarocks-packages.csv: Support luaversion
6736cc3 
Opened with libreoffice calc which added the different commas
@teto
luarocks-packages.csv: remove unnecessary servers
87d1ab0 
Now that luarocks-nix supports installation from rockspecs, it's
possible to remove some server specifications.
@teto
lua: update generated packages.nix
95d036e 
basically update nvim-client and luassert
@ofborg ofborg bot added the 6.topic: lua label Jun 4, 2019
@ofborg ofborg bot requested review from vcunat and 7c6f434c June 4, 2019 10:40
@teto
Copy link
Member Author

teto commented Jun 4, 2019

@GrahamcOfBorg build luaPackages.nvim-client luaPackages.luv luaPackages.luassert

@teto teto merged commit e496104 into NixOS:master Jun 4, 2019
@teto
Copy link
Member Author

teto commented Jun 4, 2019

thanks for the review now I can proceed to update/convert/add some more lua packages :)

@teto teto deleted the lua_update branch June 4, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @7c6f434c