Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomachine-client: 6.6.8 -> 6.7.6 #62727

Merged
merged 1 commit into from Jun 17, 2019
Merged

nomachine-client: 6.6.8 -> 6.7.6 #62727

merged 1 commit into from Jun 17, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jun 5, 2019 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (a reduction of ~4M)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmahut
mmahut approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@talyz
Copy link
Contributor Author

talyz commented Jun 6, 2019

Forgot to mention that this should be ported to stable, since nomachine doesn't keep old releases around.

@etu etu merged commit fac8d2d into NixOS:master Jun 17, 2019
@etu etu mentioned this pull request Jun 17, 2019
Merged
10 tasks
@talyz talyz deleted the nomachine-6.7.6 branch June 16, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talyz @mmahut @etu