Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-wayland: Add missing dependency libglvnd (libEGL) #62728

Merged
merged 1 commit into from Jun 5, 2019
Merged

firefox-wayland: Add missing dependency libglvnd (libEGL) #62728

merged 1 commit into from Jun 5, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jun 5, 2019

Motivation for this change

Firefox running in wayland mode is unable to find and load
libEGL.so (and says so on stdout). This puts it in "basic"
mode (unaccelerated graphics) and disables WebGL. Fix this by adding
libglvnd to the LD_LIBRARY_PATH.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
firefox-wayland: Add missing dependency libglvnd (libEGL)
ae2778c 
Firefox running in wayland mode is unable to find and load
libEGL.so (and says so on stdout). This puts it in "basic"
mode (unaccelerated graphics) and disables WebGL. Fix this by adding
libglvnd to the LD_LIBRARY_PATH.
@andir
Copy link
Member

andir commented Jun 5, 2019

Thanks! I have seen the error but never got to track it down.

@andir andir merged commit 18a2a96 into NixOS:master Jun 5, 2019
@andir
Copy link
Member

andir commented Jun 5, 2019

tested & backported in 17ebcb4

@talyz talyz deleted the firefox-wayland branch June 16, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @andir