Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbus: 1.12.12 -> 1.12.14 #61639

Merged
merged 1 commit into from Jun 5, 2019
Merged

dbus: 1.12.12 -> 1.12.14 #61639

merged 1 commit into from Jun 5, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 17, 2019

Motivation for this change

https://gitlab.freedesktop.org/dbus/dbus/blob/dbus-1.12.14/NEWS

Critical, please read NEWS carefully! (looks NixOS-friendly, but JIC)

Still rebuilding before can say it boots :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace self-assigned this May 20, 2019
@dtzWill
Copy link
Member Author

dtzWill commented May 21, 2019

So far so good on my machines, FWIW!

@FRidh FRidh added this to the 19.09 milestone May 28, 2019
@dtzWill
Copy link
Member Author

dtzWill commented May 31, 2019

/me pokes @worldofpeace

No need to hurry but just reminding you :).

@worldofpeace worldofpeace merged commit eb7c14f into NixOS:staging Jun 5, 2019
@worldofpeace
Copy link
Contributor

Looked fine, checked and it's going good in other distros too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@worldofpeace worldofpeace

Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @worldofpeace @FRidh